chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h - Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor

Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h

index cf3e2e2cc9e2ea987bf3caa4c2193f10cddb8c87..a0d1d47c3365db4705af92ac2b8ac4fe94d22036 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h

@@ -30,9 +30,8 @@

class BookmarkModelObserverForCocoa : public bookmarks::BookmarkModelObserver {

public:

- // Callback called on a significant model change. |nodeWasDeleted| will

- // be YES if an observed node was deleted in the change.

- typedef void(^ChangeCallback)(BOOL nodeWasDeleted);

+ // Callback called on a significant model change.

+ typedef void (^ChangeCallback)();

// When a |model| changes, or an observed node within it does, call a

// |callback|.

@@ -89,9 +88,8 @@ class BookmarkModelObserverForCocoa : public bookmarks::BookmarkModelObserver {

nodes_; // Weak items owned by a BookmarkModel.

base::mac::ScopedBlock<ChangeCallback> callback_;

- // Send a notification to the client; |deleted| is YES if an observed node was

- // deleted in the change.

- void Notify(BOOL deleted);

+ // Send a notification to the client.

+ void Notify();

DISALLOW_COPY_AND_ASSIGN(BookmarkModelObserverForCocoa);

};