chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm - Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor

Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

index 2dd4798ca2cc2787c282291401c3df2f506d4a42..bb689e5d4f5d82c47e4a17dac17b922fa5641bf4 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

@@ -24,15 +24,6 @@ using bookmarks::BookmarkNode;

// The opacity of the bookmark button drag image.

static const CGFloat kDragImageOpacity = 0.7;

-namespace bookmark_button {

-NSString* const kPulseBookmarkButtonNotification =

- @"PulseBookmarkButtonNotification";

-NSString* const kBookmarkKey = @"BookmarkKey";

-NSString* const kBookmarkPulseFlagKey = @"BookmarkPulseFlagKey";

-};

namespace {

// We need a class variable to track the current dragged button to enable

// proper live animated dragging behavior, and can't do it in the