chrome/browser/ui/cocoa/bookmarks/bookmark_button.h - Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_button.h

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor

Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button.h

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h

index 90af2ad19fb93d781acc52127c3c2aa2230e9361..25d73b0d2b6cd781083959cc163595ddf7ca58b6 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h

@@ -252,17 +252,3 @@ class BookmarkNode;

- (void)beginDrag:(NSEvent*)event;

@end

-namespace bookmark_button {

-// Notifications for pulsing of bookmarks.

-extern NSString* const kPulseBookmarkButtonNotification;

-// Key for userInfo dict of a kPulseBookmarkButtonNotification.

-// Value is a [NSValue valueWithPointer:]; pointer is a (const BookmarkNode*).

-extern NSString* const kBookmarkKey;

-// Key for userInfo dict of a kPulseBookmarkButtonNotification.

-// Value is a [NSNumber numberWithBool:] to turn pulsing on or off.

-extern NSString* const kBookmarkPulseFlagKey;

-};