Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr…

Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to represent caret position and text selection on Windows.

BUG=516869
R=dmazzoni@chromium.org

Committed: https://crrev.com/76e1a77f80c13c745b9740f33f767aa965f2841e
Cr-Commit-Position: refs/heads/master@{#349575}

[dmazzoni, 2015-09-08 21:18:44]

https://codereview.chromium.org/1308153012/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1308153012/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_win.cc:3756: if
(HasState(ui::AX_STATE_EDITABLE) &&
We already have IsEditableText - could you modify that to do the right thing and
then call that from here?

https://codereview.chromium.org/1308153012/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_win.cc:4021: ia2_state |=
IA2_STATE_EDITABLE;
Can you fix this line too?

https://codereview.chromium.org/1308153012/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_win.cc:4027: ia2_state |=
IA2_STATE_EDITABLE;
This line is probably wrong now, hopefully we can delete it

https://codereview.chromium.org/1308153012/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_win.cc:4432: ia2_state |=
IA2_STATE_EDITABLE;
This should hopefully no longer be needed now - and look for all other uses of
IA2_STATE_EDITABLE

[chromium-reviews, 2015-09-09 01:31:48]

Done.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-09-10 18:44:24]

lgtm with one important fix

https://codereview.chromium.org/1308153012/diff/20001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/1308153012/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:2653: } else if
(ia_role() == ROLE_SYSTEM_TEXT && IsEditableText()) {
I think you got this backwards. The previous logic checked if its editable state
was *not* set.

[nektarios, 2015-09-18 00:15:22]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-09-18 00:15:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1308153012/#ps80001
(title: "Fixed unit test by adding EDITABLE role manually.")

[commit-bot: I haz the power, 2015-09-18 00:16:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308153012/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308153012/80001

[commit-bot: I haz the power, 2015-09-18 01:24:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-18 01:25:44]

Patchset 5 (id:??) landed as
https://crrev.com/76e1a77f80c13c745b9740f33f767aa965f2841e
Cr-Commit-Position: refs/heads/master@{#349575}