content/renderer/accessibility/blink_ax_tree_source.cc - Issue 1308153012: Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 1308153012: Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed unit test by adding EDITABLE role manually. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/accessibility/blink_ax_enum_conversion.cc ('k') | content/test/data/accessibility/aria/aria-searchbox-expected-win.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 7254ca2a42ec5d02008fd649421326ff5aec777c..d765d8e26d4360e2bd61848d2143f9ad61746983 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -392,7 +392,7 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

dst->html_attributes.push_back(std::make_pair(name, value));

}

- if (!src.isReadOnly() || dst->role == ui::AX_ROLE_TEXT_FIELD) {

+ if (src.isEditable()) {

dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, src.selectionStart());

dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, src.selectionEnd());