Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: components/test_runner/web_ax_object_proxy.cc

Issue 1308153012: Uses isEditable and isRichlyEditable to determine which attributes to expose on Mac and how to repr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit test by adding EDITABLE role manually. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/web_ax_object_proxy.cc
diff --git a/components/test_runner/web_ax_object_proxy.cc b/components/test_runner/web_ax_object_proxy.cc
index 0926f31b2cf12d29bf3d9e8ef11e4d61d11e3bab..38c6afd513946392debf477c2e2d80ac40809b2d 100644
--- a/components/test_runner/web_ax_object_proxy.cc
+++ b/components/test_runner/web_ax_object_proxy.cc
@@ -508,6 +508,7 @@ WebAXObjectProxy::GetObjectTemplateBuilder(v8::Isolate* isolate) {
&WebAXObjectProxy::SelectionEndLineNumber)
.SetProperty("isEnabled", &WebAXObjectProxy::IsEnabled)
.SetProperty("isRequired", &WebAXObjectProxy::IsRequired)
+ .SetProperty("isEditable", &WebAXObjectProxy::IsEditable)
.SetProperty("isRichlyEditable", &WebAXObjectProxy::IsRichlyEditable)
.SetProperty("isFocused", &WebAXObjectProxy::IsFocused)
.SetProperty("isFocusable", &WebAXObjectProxy::IsFocusable)
@@ -834,6 +835,11 @@ bool WebAXObjectProxy::IsRequired() {
return accessibility_object_.isRequired();
}
+bool WebAXObjectProxy::IsEditable() {
+ accessibility_object_.updateLayoutAndCheckValidity();
+ return accessibility_object_.isEditable();
+}
+
bool WebAXObjectProxy::IsRichlyEditable() {
accessibility_object_.updateLayoutAndCheckValidity();
return accessibility_object_.isRichlyEditable();
« no previous file with comments | « components/test_runner/web_ax_object_proxy.h ('k') | content/browser/accessibility/accessibility_win_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698