Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308073007: Don't special case transition-property: all in parsing and data storage (Closed)

Created:
5 years, 4 months ago by Timothy Loh
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't special case transition-property: all in parsing and data storage Since 'all' is a CSS property (a shorthand for almost every other property), we shouldn't need special logic to handle it during parsing. For efficiency, it is still special-cased when we compute which transitions to start. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201196

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSTransitionData.h View 3 chunks +6 lines, -7 lines 2 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Timothy Loh
Just a random thought I had, WDYT?
5 years, 4 months ago (2015-08-26 02:05:33 UTC) #2
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/1308073007/diff/1/Source/core/animation/css/CSSTransitionData.h File Source/core/animation/css/CSSTransitionData.h (right): https://codereview.chromium.org/1308073007/diff/1/Source/core/animation/css/CSSTransitionData.h#newcode17 Source/core/animation/css/CSSTransitionData.h:17: TransitionNone, Unrelated to this patch but I'm not ...
5 years, 3 months ago (2015-08-26 02:57:17 UTC) #3
Timothy Loh
https://codereview.chromium.org/1308073007/diff/1/Source/core/animation/css/CSSTransitionData.h File Source/core/animation/css/CSSTransitionData.h (right): https://codereview.chromium.org/1308073007/diff/1/Source/core/animation/css/CSSTransitionData.h#newcode17 Source/core/animation/css/CSSTransitionData.h:17: TransitionNone, On 2015/08/26 02:57:17, alancutter wrote: > Unrelated to ...
5 years, 3 months ago (2015-08-26 03:36:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308073007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308073007/1
5 years, 3 months ago (2015-08-26 03:37:04 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 04:29:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201196

Powered by Google App Engine
This is Rietveld 408576698