Don't special case transition-property: all in parsing and data storage

Source/core/animation/css/CSSTransitionData.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CSSTransitionData_h
 #define CSSTransitionData_h
 
 #include "core/CSSPropertyNames.h"
 #include "core/animation/css/CSSTimingData.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
 class CSSTransitionData final : public CSSTimingData {
 public:
     enum TransitionPropertyType {
         TransitionNone,

[alancutter (OOO until 2018), 2015/08/26 02:57:17]

Unrelated to this patch but I'm not sure why we represent none as TransitionNone
instead of an empty TransitionProperty list.

[Timothy Loh, 2015/08/26 03:36:37]

Probably to make it consistent with the other transition and animation values so
it doesn't need special casing in the generated code.

-        TransitionSingleProperty,
-        TransitionUnknown,
-        TransitionAll
+        TransitionKnownProperty,
+        TransitionUnknownProperty,
     };
 
     // FIXME: We shouldn't allow 'none' to be used alongside other properties.
     struct TransitionProperty {
         ALLOW_ONLY_INLINE_ALLOCATION();
         TransitionProperty(CSSPropertyID id)
-            : propertyType(TransitionSingleProperty)
+            : propertyType(TransitionKnownProperty)
             , unresolvedProperty(id)
         {
             ASSERT(id != CSSPropertyInvalid);
         }
 
         TransitionProperty(const String& string)
-            : propertyType(TransitionUnknown)
+            : propertyType(TransitionUnknownProperty)
             , unresolvedProperty(CSSPropertyInvalid)
             , propertyString(string)
         {
         }
 
         TransitionProperty(TransitionPropertyType type)
             : propertyType(type)
             , unresolvedProperty(CSSPropertyInvalid)
         {
-            ASSERT(type == TransitionNone || type == TransitionAll);
+            ASSERT(type == TransitionNone);
         }
 
         bool operator==(const TransitionProperty& other) const { return propertyType == other.propertyType && unresolvedProperty == other.unresolvedProperty && propertyString == other.propertyString; }
 
         TransitionPropertyType propertyType;
         CSSPropertyID unresolvedProperty;
         String propertyString;
     };
 
     static PassOwnPtr<CSSTransitionData> create()
     {
         return adoptPtr(new CSSTransitionData);
     }
 
     static PassOwnPtr<CSSTransitionData> create(const CSSTransitionData& transitionData)
     {
         return adoptPtr(new CSSTransitionData(transitionData));
     }
 
     bool transitionsMatchForStyleRecalc(const CSSTransitionData& other) const;
 
     Timing convertToTiming(size_t index) const;
 
     const Vector<TransitionProperty>& propertyList() const { return m_propertyList; }
     Vector<TransitionProperty>& propertyList() { return m_propertyList; }
 
-    static TransitionProperty initialProperty() { return TransitionProperty(TransitionAll); }
+    static TransitionProperty initialProperty() { return TransitionProperty(CSSPropertyAll); }
 
 private:
     CSSTransitionData();
     explicit CSSTransitionData(const CSSTransitionData&);
 
     Vector<TransitionProperty> m_propertyList;
 };
 
 } // namespace blink
 
 #endif // CSSTransitionData_h