Source/core/css/parser/CSSPropertyParser.cpp - Issue 1308073007: Don't special case transition-property: all in parsing and data storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1308073007: Don't special case transition-property: all in parsing and data storage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/css/CSSTransitionData.h ('K') | « Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | Source/core/css/resolver/CSSToStyleMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index 3800340654cf97a7ff909a178623ac0fd2bd54c2..297c950f6a625605f17ba5efa562749525af51b1 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -3056,11 +3056,6 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseAnimationProperty()

CSSParserValue* value = m_valueList->current();

if (value->m_unit != CSSParserValue::Identifier)

return nullptr;

- // Since all is valid css property keyword, cssPropertyID for all

- // returns non-null value. We need to check "all" before

- // cssPropertyID check.

- if (value->id == CSSValueAll)

- return cssValuePool().createIdentifierValue(CSSValueAll);

CSSPropertyID property = unresolvedCSSPropertyID(value->string);

if (property) {

ASSERT(CSSPropertyMetadata::isEnabledProperty(property));