Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1307203006: telemetry: Fix startup benchmarks so that all metrics get recorded. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

telemetry: Fix startup benchmarks so that all metrics get recorded. *PERF SHERRIF: if startup benchmarks become red, this CL is to be reverted. The lack of a page navigation was preventing the metric Startup.FirstWebContents.NonEmptyPaint from being emitted. The addition of the RAF logic check is to prevent theoretical race conditions - it may be overkill. BUG=513364 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/0bc400e1c96da5a05379bc1b634ec278f36d3417 Cr-Commit-Position: refs/heads/master@{#347402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M tools/perf/measurements/startup.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/page_sets/blank_page.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
erikchen
nednguyen: Please review. See https://code.google.com/p/chromium/issues/detail?id=513364#c11 for details about RAF.
5 years, 3 months ago (2015-09-04 01:10:39 UTC) #2
nednguyen
lgtm
5 years, 3 months ago (2015-09-04 01:36:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
5 years, 3 months ago (2015-09-04 01:37:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/107674)
5 years, 3 months ago (2015-09-04 01:43:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
5 years, 3 months ago (2015-09-04 01:55:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/107683)
5 years, 3 months ago (2015-09-04 02:01:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
5 years, 3 months ago (2015-09-04 02:02:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/65629) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-04 02:06:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
5 years, 3 months ago (2015-09-04 05:07:26 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/3582)
5 years, 3 months ago (2015-09-04 12:50:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
5 years, 3 months ago (2015-09-04 13:27:34 UTC) #21
nednguyen
On 2015/09/04 13:27:34, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 3 months ago (2015-09-04 14:30:15 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 14:31:59 UTC) #23
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0bc400e1c96da5a05379bc1b634ec278f36d3417 Cr-Commit-Position: refs/heads/master@{#347402}
5 years, 3 months ago (2015-09-04 14:32:46 UTC) #24
erikchen
5 years, 1 month ago (2015-11-10 22:15:52 UTC) #25
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1438533003/ by erikchen@chromium.org.

The reason for reverting is: Theoretically, these changes should no longer be
required, now that https://code.google.com/p/chromium/issues/detail?id=529340#c7
has landed..

Powered by Google App Engine
This is Rietveld 408576698