|
|
Descriptiontelemetry: Fix startup benchmarks so that all metrics get recorded.
*PERF SHERRIF: if startup benchmarks become red, this CL is to be reverted.
The lack of a page navigation was preventing the metric
Startup.FirstWebContents.NonEmptyPaint from being emitted. The addition of the
RAF logic check is to prevent theoretical race conditions - it may be overkill.
BUG=513364
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Committed: https://crrev.com/0bc400e1c96da5a05379bc1b634ec278f36d3417
Cr-Commit-Position: refs/heads/master@{#347402}
Patch Set 1 #
Messages
Total messages: 25 (10 generated)
erikchen@chromium.org changed reviewers: + nednguyen@google.com
nednguyen: Please review. See https://code.google.com/p/chromium/issues/detail?id=513364#c11 for details about RAF.
lgtm
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1
On 2015/09/04 13:27:34, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1307203006/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1307203006/1 I removed win_perf_bisect from the list of CQ_EXTRA_TRYBOTS.
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0bc400e1c96da5a05379bc1b634ec278f36d3417 Cr-Commit-Position: refs/heads/master@{#347402}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1438533003/ by erikchen@chromium.org. The reason for reverting is: Theoretically, these changes should no longer be required, now that https://code.google.com/p/chromium/issues/detail?id=529340#c7 has landed.. |