tools/perf/measurements/startup.py - Issue 1307203006: telemetry: Fix startup benchmarks so that all metrics get recorded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/startup.py

Issue 1307203006: telemetry: Fix startup benchmarks so that all metrics get recorded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/startup.py

diff --git a/tools/perf/measurements/startup.py b/tools/perf/measurements/startup.py

index 6acf9d2c65b4da9147d5bf604933b70a9538df97..e1cbc3ace9225a70ec725084cfdd62ea76b95d20 100644

--- a/tools/perf/measurements/startup.py

+++ b/tools/perf/measurements/startup.py

@@ -29,10 +29,6 @@ class Startup(page_test.PageTest):

])

keychain_metric.KeychainMetric.CustomizeBrowserOptions(options)

- def RunNavigateSteps(self, page, tab):

- # Overriden so that no page navigation occurs - startup to the NTP.

- pass

def ValidateAndMeasurePage(self, page, tab, results):

keychain_metric.KeychainMetric().AddResults(tab, results)

startup_metric.StartupMetric().AddResults(tab, results)

« no previous file with comments | « no previous file | tools/perf/page_sets/blank_page.py » ('j') | no next file with comments »