Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 1438533003: Revert of telemetry: Fix startup benchmarks so that all metrics get recorded. (Closed)

Created:
5 years, 1 month ago by erikchen
Modified:
5 years, 1 month ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of telemetry: Fix startup benchmarks so that all metrics get recorded. Reason for revert: Theoretically, these changes should no longer be required, now that https://code.google.com/p/chromium/issues/detail?id=529340#c7 has landed. Original issue's description: > telemetry: Fix startup benchmarks so that all metrics get recorded. > > *PERF SHERRIF: if startup benchmarks become red, this CL is to be reverted. > > The lack of a page navigation was preventing the metric > Startup.FirstWebContents.NonEmptyPaint from being emitted. The addition of the > RAF logic check is to prevent theoretical race conditions - it may be overkill. > > BUG=513364 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/0bc400e1c96da5a05379bc1b634ec278f36d3417 > Cr-Commit-Position: refs/heads/master@{#347402} TBR=nednguyen@google.com BUG=513364 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/359e8b1514eba38cb34d72443c223f49d1a55656 Cr-Commit-Position: refs/heads/master@{#359024}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M tools/perf/measurements/startup.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/perf/page_sets/blank_page.py View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
erikchen
Created Revert of telemetry: Fix startup benchmarks so that all metrics get recorded.
5 years, 1 month ago (2015-11-10 22:15:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438533003/1
5 years, 1 month ago (2015-11-10 22:17:27 UTC) #2
commit-bot: I haz the power
Failed to apply patch for tools/perf/page_sets/blank_page.py: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-11-10 22:19:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438533003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438533003/70001
5 years, 1 month ago (2015-11-10 22:25:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/133091)
5 years, 1 month ago (2015-11-11 00:19:49 UTC) #9
erikchen
On 2015/11/11 00:19:49, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-11 00:20:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438533003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438533003/70001
5 years, 1 month ago (2015-11-11 00:22:40 UTC) #12
nednguyen
On 2015/11/11 00:20:53, erikchen wrote: > On 2015/11/11 00:19:49, commit-bot: I haz the power wrote: ...
5 years, 1 month ago (2015-11-11 00:33:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:70001)
5 years, 1 month ago (2015-11-11 02:34:14 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/359e8b1514eba38cb34d72443c223f49d1a55656 Cr-Commit-Position: refs/heads/master@{#359024}
5 years, 1 month ago (2015-11-11 02:34:57 UTC) #15
erikchen
5 years ago (2015-11-24 18:51:04 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:70001) has been created in
https://codereview.chromium.org/1475773003/ by erikchen@chromium.org.

The reason for reverting is: Looks like my changes were still required to get
the metric:

foreground_tab_request_start

https://code.google.com/p/chromium/issues/detail?id=560760&q=owner%3Aerikchen....

Powered by Google App Engine
This is Rietveld 408576698