Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307203004: Revert "Reworks the clipping logic" and follow-up. (Closed)

Created:
5 years, 3 months ago by Julien - ping for review
Modified:
5 years, 3 months ago
Reviewers:
eae, ojan
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Reworks the clipping logic" and follow-up. This change reverts commit f5bd7257166f313f8bed1ceffa2802e6540b53da and 25907d23a2b4a963c879fb44c18ed05ad388f00e. The change has been the cause of numerous regressions (painting and hit-testing clip rects wrongly computed) and several performance regressions. Reverting the change so that I can investigate offline and reland in a smaller bits. BUG=518215, 521452, 522829, 518219 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -320 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/layout/ClipRect.h View 2 chunks +0 lines, -18 lines 0 comments Download
M Source/core/layout/ClipRects.h View 3 chunks +12 lines, -24 lines 0 comments Download
M Source/core/layout/ClipRectsCache.h View 2 chunks +31 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/CompositingInputsUpdater.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.h View 3 chunks +19 lines, -31 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.cpp View 2 chunks +144 lines, -228 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Julien - ping for review
Ojan: FYI Any reviewer, it's more or less a RS as it's a revert (though ...
5 years, 3 months ago (2015-09-02 23:43:56 UTC) #2
eae
LGTM
5 years, 3 months ago (2015-09-03 18:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307203004/1
5 years, 3 months ago (2015-09-03 19:51:44 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 20:29:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201739

Powered by Google App Engine
This is Rietveld 408576698