Revert "Reworks the clipping logic" and follow-up.

Source/core/paint/DeprecatedPaintLayerClipper.h

 /*
  * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
@@ skipping 27 matching lines @@
  * version of this file under the LGPL, indicate your decision by
  * deletingthe provisions above and replace them with the notice and
  * other provisions required by the MPL or the GPL, as the case may be.
  * If you do not delete the provisions above, a recipient may use your
  * version of this file under any of the LGPL, the MPL or the GPL.
  */
 
 #ifndef DeprecatedPaintLayerClipper_h
 #define DeprecatedPaintLayerClipper_h
 
-#include "core/layout/ClipRects.h"
 #include "core/layout/ClipRectsCache.h"
 #include "core/layout/LayoutBox.h"
 #include "wtf/Allocator.h"
 
 namespace blink {
 
 class DeprecatedPaintLayer;
 
-// This is the state information passed down
-// on the stack for calculating clip rects.
-struct ClipRectComputationState {
-    STACK_ALLOCATED();
-    ClipRectComputationState()
-    {
-        currentClipRects.reset(LayoutRect(LayoutRect::infiniteIntRect()));
-        stackingContextClipRects.reset(LayoutRect(LayoutRect::infiniteIntRect()));
-    }
-    // Depending on the value of context.isComputingPaintingRect() can have different meanings
-    // In painting, this ClipRects is used for statically positioned elements,
-    // outside painting, it is the only ClipRects, and is used for all elements.
-    ClipRects currentClipRects;
-    // During painting this ClipRects is used for positioned elements. It can have
-    // a rootLayer further up the tree than currentClipRects because its root must be
-    // beyond the enclosing stacking context. See resetPaintRects.
-    ClipRects stackingContextClipRects;
-};
-
 enum ShouldRespectOverflowClip {
     IgnoreOverflowClip,
     RespectOverflowClip
 };
 
 class ClipRectsContext {
     STACK_ALLOCATED();
 public:
     ClipRectsContext(const DeprecatedPaintLayer* root, ClipRectsCacheSlot slot, OverlayScrollbarSizeRelevancy relevancy = IgnoreOverlayScrollbarSize, const LayoutSize& accumulation = LayoutSize())
         : rootLayer(root)
@@ skipping 56 matching lines @@
     ClipRects* getClipRects(const ClipRectsContext&) const;
 
     ClipRect backgroundClipRect(const ClipRectsContext&) const;
 
     // This method figures out our layerBounds in coordinates relative to
     // |rootLayer|. It also computes our background and foreground clip rects
     // for painting/event handling.
     // Pass offsetFromRoot if known.
     void calculateRects(const ClipRectsContext&, const LayoutRect& paintDirtyRect, LayoutRect& layerBounds,
         ClipRect& backgroundRect, ClipRect& foregroundRect, ClipRect& outlineRect, const LayoutPoint* offsetFromRoot = 0) const;
-    void calculateClipRects(const ClipRectsContext&, ClipRectComputationState&) const;
+private:
+    void calculateClipRects(const ClipRectsContext&, ClipRects&) const;
+    ClipRects* clipRectsIfCached(const ClipRectsContext&) const;
+    ClipRects* storeClipRectsInCache(const ClipRectsContext&, ClipRects* parentClipRects, const ClipRects&) const;
+
+    // cachedClipRects looks buggy: It doesn't check whether context.rootLayer and entry.root match.
+    // FIXME: Move callers to clipRectsIfCached, which does the proper checks.
+    ClipRects* cachedClipRects(const ClipRectsContext& context) const
+    {
+        return m_cache ? m_cache->get(context.cacheSlot()).clipRects.get() : 0;
+    }
+    void getOrCalculateClipRects(const ClipRectsContext&, ClipRects&) const;
 
     DeprecatedPaintLayer* clippingRootForPainting() const;
 
-    void precalculateAbsoluteClipRects();
-
-private:
-    void setClipRect(const ClipRectsContext&, const ClipRectComputationState&) const;
-    void addClipsFromThisObject(const ClipRectsContext&, ClipRects&) const;
-    void updateClipRectBasedOnPosition(ClipRects*) const;
-
-    ClipRect uncachedBackgroundClipRect(const ClipRectsContext&) const;
-    void uncachedCalculateClipRects(const ClipRectsContext&, ClipRects&) const;
+    ClipRectsCache& cache() const
+    {
+        if (!m_cache)
+            m_cache = adoptPtr(new ClipRectsCache);
+        return *m_cache;
+    }
 
     bool shouldRespectOverflowClip(const ClipRectsContext&) const;
 
     // FIXME: Could this be a LayoutBox?
     LayoutBoxModelObject& m_layoutObject;
-    mutable OwnPtr<ClipRect> m_clips[NumberOfClipRectsCacheSlots];
+    mutable OwnPtr<ClipRectsCache> m_cache;
 };
 
 } // namespace blink
 
 #endif // LayerClipper_h