Source/core/css/parser/CSSParserValuesTest.cpp - Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserValuesTest.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values

Patch Set: Fixing tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSStringValueBase.h ('K') | « Source/core/css/parser/CSSParserValues.cpp ('k') | Source/core/css/parser/CSSPropertyParser.h » ('j') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSParserValuesTest.cpp

diff --git a/Source/core/css/parser/CSSParserValuesTest.cpp b/Source/core/css/parser/CSSParserValuesTest.cpp

index 546ce851d92d8a3b1fc3e8aa739d1a249044be6d..47664e92f210896086ced0c154949ba75304f355 100644

--- a/Source/core/css/parser/CSSParserValuesTest.cpp

+++ b/Source/core/css/parser/CSSParserValuesTest.cpp

@@ -106,13 +106,13 @@ TEST(CSSParserValuesTest, CSSParserTokenUrlConversion)

CSSTokenizer::Scope scope("url(some) uRL('test') UrL( \"words\" /**/ ) URl( /**/hi/**/ )");

CSSParserValueList valueList(scope.tokenRange());

ASSERT_EQ(valueList.size(), 4u);

- ASSERT_EQ(valueList.valueAt(0)->unit(), CSSPrimitiveValue::UnitType::URI);

+ ASSERT_EQ(valueList.valueAt(0)->m_unit, CSSParserValue::URI);

EXPECT_EQ(String(valueList.valueAt(0)->string), "some");

- ASSERT_EQ(valueList.valueAt(1)->unit(), CSSPrimitiveValue::UnitType::URI);

+ ASSERT_EQ(valueList.valueAt(1)->m_unit, CSSParserValue::URI);

EXPECT_EQ(String(valueList.valueAt(1)->string), "test");

- ASSERT_EQ(valueList.valueAt(2)->unit(), CSSPrimitiveValue::UnitType::URI);

+ ASSERT_EQ(valueList.valueAt(2)->m_unit, CSSParserValue::URI);

EXPECT_EQ(String(valueList.valueAt(2)->string), "words");

- ASSERT_EQ(valueList.valueAt(3)->unit(), CSSPrimitiveValue::UnitType::URI);

+ ASSERT_EQ(valueList.valueAt(3)->m_unit, CSSParserValue::URI);

EXPECT_EQ(String(valueList.valueAt(3)->string), "/**/hi/**/");

}