Source/core/css/parser/CSSParserValuesTest.cpp - Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/css/parser/CSSParserValuesTest.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values

Patch Set: Fixing tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/css/CSSStringValueBase.h ('K') | « Source/core/css/parser/CSSParserValues.cpp ('k') | Source/core/css/parser/CSSPropertyParser.h » ('j') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright 2013, Google Inc. All rights reserved.	2 * Copyright 2013, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 88 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99 list.clearAndLeakValues();	99 list.clearAndLeakValues();

100 ASSERT_FALSE(list.size());	100 ASSERT_FALSE(list.size());

101 ASSERT_FALSE(list.currentIndex());	101 ASSERT_FALSE(list.currentIndex());

102 }	102 }

103	103

104 TEST(CSSParserValuesTest, CSSParserTokenUrlConversion)	104 TEST(CSSParserValuesTest, CSSParserTokenUrlConversion)

105 {	105 {

106 CSSTokenizer::Scope scope("url(some) uRL('test') UrL( \"words\" // ) URl( //hi/**/ )");	106 CSSTokenizer::Scope scope("url(some) uRL('test') UrL( \"words\" // ) URl( //hi/**/ )");

107 CSSParserValueList valueList(scope.tokenRange());	107 CSSParserValueList valueList(scope.tokenRange());

108 ASSERT_EQ(valueList.size(), 4u);	108 ASSERT_EQ(valueList.size(), 4u);

109 ASSERT_EQ(valueList.valueAt(0)->unit(), CSSPrimitiveValue::UnitType::URI);	109 ASSERT_EQ(valueList.valueAt(0)->m_unit, CSSParserValue::URI);

110 EXPECT_EQ(String(valueList.valueAt(0)->string), "some");	110 EXPECT_EQ(String(valueList.valueAt(0)->string), "some");

111 ASSERT_EQ(valueList.valueAt(1)->unit(), CSSPrimitiveValue::UnitType::URI);	111 ASSERT_EQ(valueList.valueAt(1)->m_unit, CSSParserValue::URI);

112 EXPECT_EQ(String(valueList.valueAt(1)->string), "test");	112 EXPECT_EQ(String(valueList.valueAt(1)->string), "test");

113 ASSERT_EQ(valueList.valueAt(2)->unit(), CSSPrimitiveValue::UnitType::URI);	113 ASSERT_EQ(valueList.valueAt(2)->m_unit, CSSParserValue::URI);

114 EXPECT_EQ(String(valueList.valueAt(2)->string), "words");	114 EXPECT_EQ(String(valueList.valueAt(2)->string), "words");

115 ASSERT_EQ(valueList.valueAt(3)->unit(), CSSPrimitiveValue::UnitType::URI);	115 ASSERT_EQ(valueList.valueAt(3)->m_unit, CSSParserValue::URI);

116 EXPECT_EQ(String(valueList.valueAt(3)->string), "//hi//");	116 EXPECT_EQ(String(valueList.valueAt(3)->string), "//hi//");

117 }	117 }

118	118

119 } // namespace blink	119 } // namespace blink

OLD	NEW