Source/core/css/parser/CSSParserValues.cpp - Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserValues.cpp

Issue 1306823004: Split out String, URI and CustomIdent from CSSPrimitiveValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_attr_values

Patch Set: Fixing tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSStringValueBase.h ('K') | « Source/core/css/parser/CSSParserValues.h ('k') | Source/core/css/parser/CSSParserValuesTest.cpp » ('j') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSParserValues.cpp

diff --git a/Source/core/css/parser/CSSParserValues.cpp b/Source/core/css/parser/CSSParserValues.cpp

index ec23f0e13357c0b31ffa0838c60642d0f79bafa2..c2644573c35f30737fbd8efa16ebc6f39aafc8d4 100644

--- a/Source/core/css/parser/CSSParserValues.cpp

+++ b/Source/core/css/parser/CSSParserValues.cpp

@@ -57,7 +57,7 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range)

ASSERT(next.type() == StringToken);

value.id = CSSValueInvalid;

value.isInt = false;

- value.setUnit(CSSPrimitiveValue::UnitType::URI);

+ value.m_unit = CSSParserValue::URI;

value.string = next.value();

break;

}

@@ -164,9 +164,9 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range)

if (token.type() == HashToken)

value.m_unit = CSSParserValue::HexColor;

else if (token.type() == StringToken)

- value.setUnit(CSSPrimitiveValue::UnitType::String);

+ value.m_unit = CSSParserValue::String;

else

- value.setUnit(CSSPrimitiveValue::UnitType::URI);

+ value.m_unit = CSSParserValue::URI;

value.string = token.value();

break;

}