content/renderer/media/renderer_gpu_video_accelerator_factories.h - Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer.

Unified Diff: content/renderer/media/renderer_gpu_video_accelerator_factories.h

Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Address andresantoso's comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/renderer_gpu_video_accelerator_factories.h

diff --git a/content/renderer/media/renderer_gpu_video_accelerator_factories.h b/content/renderer/media/renderer_gpu_video_accelerator_factories.h

index 981fc656a46ae0998c77e9ed9dd390f36741df85..db3715bf8f474bcda5081cf3b36ed893527c3845 100644

--- a/content/renderer/media/renderer_gpu_video_accelerator_factories.h

+++ b/content/renderer/media/renderer_gpu_video_accelerator_factories.h

@@ -49,6 +49,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

const scoped_refptr<ContextProviderCommandBuffer>& context_provider,

bool enable_gpu_memory_buffer_video_frames,

unsigned image_texture_target,

+ media::VideoPixelFormat video_frame_pixel_format,

bool enable_video_accelerator);

bool IsGpuVideoAcceleratorEnabled() override;

@@ -75,6 +76,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

bool IsTextureRGSupported() override;

bool ShouldUseGpuMemoryBuffersForVideoFrames() const override;

unsigned ImageTextureTarget() override;

+ media::VideoPixelFormat VideoFramePixelFormat() override;

xhwang 2015/08/21 20:53:07 This is used for output frame, it seems easier to

Daniele Castagna 2015/08/21 21:28:17 Renamed to VideoFrameOutputFormat.

gpu::gles2::GLES2Interface* GetGLES2Interface() override;

scoped_ptr<base::SharedMemory> CreateSharedMemory(size_t size) override;

scoped_refptr<base::SingleThreadTaskRunner> GetTaskRunner() override;

@@ -92,6 +94,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

const scoped_refptr<ContextProviderCommandBuffer>& context_provider,

bool enable_gpu_memory_buffer_video_frames,

unsigned image_texture_target,

+ media::VideoPixelFormat video_frame_pixel_format_,

bool enable_video_accelerator);

~RendererGpuVideoAcceleratorFactories() override;

@@ -112,6 +115,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

// Wheter gpu memory buffers should be used to hold video frames data.

xhwang 2015/08/21 20:53:07 nit: Whet_h_er

Daniele Castagna 2015/08/21 21:28:17 Done. Tnx. :)

bool enable_gpu_memory_buffer_video_frames_;

const unsigned image_texture_target_;

+ const media::VideoPixelFormat video_frame_pixel_format_;

xhwang 2015/08/21 20:53:07 Add a comment for this new member.

Daniele Castagna 2015/08/21 21:28:17 Done.

// Whether video acceleration encoding/decoding should be enabled.

const bool video_accelerator_enabled_;

« no previous file with comments | « no previous file | content/renderer/media/renderer_gpu_video_accelerator_factories.cc » ('j') | content/renderer/render_thread_impl.cc » ('J')