content/renderer/render_thread_impl.cc - Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1306693002: media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Address andresantoso's comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/renderer_gpu_video_accelerator_factories.h ('K') | « content/renderer/media/renderer_gpu_video_accelerator_factories.cc ('k') | media/base/video_frame.cc » ('j') | media/base/video_frame.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_thread_impl.cc

diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc

index 585d5f1a1679a994fe95f5db6d2784d997ce4da8..0a146ea3f5316757d524627c65cf760b97dd755e 100644

--- a/content/renderer/render_thread_impl.cc

+++ b/content/renderer/render_thread_impl.cc

@@ -1365,10 +1365,15 @@ RenderThreadImpl::GetGpuFactories() {

"gpu_channel_. See crbug.com/495185.";

CHECK(gpu_channel_host.get()) << "Have gpu_va_context_provider but lost "

"gpu_channel_. See crbug.com/495185.";

+ media::VideoPixelFormat video_pixel_format = media::PIXEL_FORMAT_I420;

+#if defined(OS_MACOSX)

+ // TODO(dcastagna): Check that the extension is available.

+ video_pixel_format = media::PIXEL_FORMAT_UYVY;

reveman 2015/08/21 21:53:02 why is this not decided where we check if RG exten

+#endif

gpu_factories = RendererGpuVideoAcceleratorFactories::Create(

gpu_channel_host.get(), media_task_runner, gpu_va_context_provider_,

enable_gpu_memory_buffer_video_frames, image_texture_target,

- enable_video_accelerator);

+ video_pixel_format, enable_video_accelerator);

}

return gpu_factories;

}