media: Convert I420 VideoFrame to UYVY GpuMemoryBuffer.

content/renderer/media/renderer_gpu_video_accelerator_factories.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_RENDERER_GPU_VIDEO_ACCELERATOR_FACTORIES_H_
 #define CONTENT_RENDERER_MEDIA_RENDERER_GPU_VIDEO_ACCELERATOR_FACTORIES_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 31 matching lines @@
     : public media::GpuVideoAcceleratorFactories {
  public:
   // Takes a ref on |gpu_channel_host| and tests |context| for loss before each
   // use.  Safe to call from any thread.
   static scoped_refptr<RendererGpuVideoAcceleratorFactories> Create(
       GpuChannelHost* gpu_channel_host,
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
       const scoped_refptr<ContextProviderCommandBuffer>& context_provider,
       bool enable_gpu_memory_buffer_video_frames,
       unsigned image_texture_target,
+      media::VideoPixelFormat video_frame_pixel_format,
       bool enable_video_accelerator);
 
   bool IsGpuVideoAcceleratorEnabled() override;
   // media::GpuVideoAcceleratorFactories implementation.
   scoped_ptr<media::VideoDecodeAccelerator> CreateVideoDecodeAccelerator()
       override;
   scoped_ptr<media::VideoEncodeAccelerator> CreateVideoEncodeAccelerator()
       override;
   // Creates textures and produces them into mailboxes. Returns true on success
   // or false on failure.
   bool CreateTextures(int32 count,
                       const gfx::Size& size,
                       std::vector<uint32>* texture_ids,
                       std::vector<gpu::Mailbox>* texture_mailboxes,
                       uint32 texture_target) override;
   void DeleteTexture(uint32 texture_id) override;
   void WaitSyncPoint(uint32 sync_point) override;
 
   scoped_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBuffer(
       const gfx::Size& size,
       gfx::BufferFormat format,
       gfx::BufferUsage usage) override;
 
   bool IsTextureRGSupported() override;
   bool ShouldUseGpuMemoryBuffersForVideoFrames() const override;
   unsigned ImageTextureTarget() override;
+  media::VideoPixelFormat VideoFramePixelFormat() override;

[xhwang, 2015/08/21 20:53:07]

This is used for output frame, it seems easier to understand if you have
"output" somewhere in the naming.

[Daniele Castagna, 2015/08/21 21:28:17]

Renamed to VideoFrameOutputFormat.

   gpu::gles2::GLES2Interface* GetGLES2Interface() override;
   scoped_ptr<base::SharedMemory> CreateSharedMemory(size_t size) override;
   scoped_refptr<base::SingleThreadTaskRunner> GetTaskRunner() override;
 
   std::vector<media::VideoDecodeAccelerator::SupportedProfile>
       GetVideoDecodeAcceleratorSupportedProfiles() override;
   std::vector<media::VideoEncodeAccelerator::SupportedProfile>
       GetVideoEncodeAcceleratorSupportedProfiles() override;
 
  private:
   friend class base::RefCountedThreadSafe<RendererGpuVideoAcceleratorFactories>;
   RendererGpuVideoAcceleratorFactories(
       GpuChannelHost* gpu_channel_host,
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
       const scoped_refptr<ContextProviderCommandBuffer>& context_provider,
       bool enable_gpu_memory_buffer_video_frames,
       unsigned image_texture_target,
+      media::VideoPixelFormat video_frame_pixel_format_,
       bool enable_video_accelerator);
 
   ~RendererGpuVideoAcceleratorFactories() override;
 
   // Helper to bind |context_provider| to the |task_runner_| thread after
   // construction.
   void BindContext();
 
   // Helper to get a pointer to the WebGraphicsContext3DCommandBufferImpl,
   // if it has not been lost yet.
   WebGraphicsContext3DCommandBufferImpl* GetContext3d();
   GLHelper* GetGLHelper();
 
   scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
   scoped_refptr<GpuChannelHost> gpu_channel_host_;
   scoped_refptr<ContextProviderCommandBuffer> context_provider_;
 
   // Wheter gpu memory buffers should be used to hold video frames data.

[xhwang, 2015/08/21 20:53:07]

nit: Whet_h_er

[Daniele Castagna, 2015/08/21 21:28:17]

Done.
Tnx. :)

   bool enable_gpu_memory_buffer_video_frames_;
   const unsigned image_texture_target_;
+  const media::VideoPixelFormat video_frame_pixel_format_;

[xhwang, 2015/08/21 20:53:07]

Add a comment for this new member.

[Daniele Castagna, 2015/08/21 21:28:17]

Done.

   // Whether video acceleration encoding/decoding should be enabled.
   const bool video_accelerator_enabled_;
 
   scoped_ptr<GLHelper> gl_helper_;
   gpu::GpuMemoryBufferManager* const gpu_memory_buffer_manager_;
 
   // For sending requests to allocate shared memory in the Browser process.
   scoped_refptr<ThreadSafeSender> thread_safe_sender_;
 
   DISALLOW_COPY_AND_ASSIGN(RendererGpuVideoAcceleratorFactories);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_RENDERER_GPU_VIDEO_ACCELERATOR_FACTORIES_H_