Redefine CreateFileVersionInfoForCurrentModule() as a macro on Windows.

Redefine CreateFileVersionInfoForCurrentModule() as a macro on Windows.

This makes extra sure that inlining occurs.

When __force_inline doesn't work... brute-force-inline..!

BUG=516359
TBR=gene@chromium.org

Committed: https://crrev.com/2a85add76b2927db8249e0287dc2301b6eafd023
Cr-Commit-Position: refs/heads/master@{#346041}

[gab, 2015-08-20 15:04:40]

gab@chromium.org changed reviewers:
+ brucedawson@chromium.org

[gab, 2015-08-20 15:04:41]

@Bruce, that fixes it..! WDYT?

[robertshield, 2015-08-20 15:31:55]

On 2015/08/20 15:04:41, gab wrote:
> @Bruce, that fixes it..! WDYT?

Nice, you really did use a macro :-)

[brucedawson, 2015-08-20 18:20:55]

I hate macros, but they do have their uses. I am not an owner but lgtm.

[gab, 2015-08-20 20:08:13]

gab@chromium.org changed reviewers:
+ rvargas@chromium.org

[gab, 2015-08-20 20:08:37]

On 2015/08/20 18:20:55, brucedawson wrote:
> I hate macros, but they do have their uses. I am not an owner but lgtm.

Agreed, @Ricardo: WDYT?

[rvargas (doing something else), 2015-08-21 01:03:31]

I don't like having a method named as a function and implemented as a macro :(

I'd go with a regular macro (not part of a class, and named as a macro), but
that of course clashes with the mac implementation. We could declare the macro
on mac calling the existing method.

[gab, 2015-08-26 21:16:30]

On 2015/08/21 01:03:31, rvargas (out until 9-8) wrote:
> I don't like having a method named as a function and implemented as a macro :(
> 
> I'd go with a regular macro (not part of a class, and named as a macro), but
> that of course clashes with the mac implementation. We could declare the macro
> on mac calling the existing method.

I also don't like having a method named as a function and implemented as a
macro, but I thought it resulted in a cleaner API (i.e. the hack became an
implementation detail).

Now it's exposed to the caller and the API is uglier IMO...

Anyways, applied suggestion for now, nothing special to do for Mac as no
cross-platform code actually performs this call.

Let me know if you prefer this or prefer the smaller but hackier change I had
originally.

Thanks,
Gab

[gab, 2015-08-26 21:16:34]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-26 21:17:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306603003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306603003/20001

[brucedawson, 2015-08-26 21:20:02]

It probably is best to not hide the fact that a macro is being used. I am not an
owner but lgtm.

[commit-bot: I haz the power, 2015-08-26 22:37:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 22:37:13]

Dry run: This issue passed the CQ dry run.

[gab, 2015-08-27 20:33:21]

gab@chromium.org changed reviewers:
+ thakis@chromium.org

[gab, 2015-08-27 20:33:21]

@Nico, looks like Ricardo is out, mind taking a look?

Thanks,
Gab

[Nico, 2015-08-27 23:23:25]

lgtm

[gab, 2015-08-28 00:02:21]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2015-08-28 00:02:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306603003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306603003/20001

[gab, 2015-08-28 00:03:34]

gab@chromium.org changed reviewers:
+ gene@chromium.org

[gab, 2015-08-28 00:03:41]

The CQ bit was unchecked by gab@chromium.org

[gab, 2015-08-28 00:03:56]

TBR gene for side-effect on cloud_print/

[gab, 2015-08-28 00:04:25]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2015-08-28 00:04:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1306603003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1306603003/20001

[commit-bot: I haz the power, 2015-08-28 01:13:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-28 01:14:05]

Patchset 2 (id:??) landed as
https://crrev.com/2a85add76b2927db8249e0287dc2301b6eafd023
Cr-Commit-Position: refs/heads/master@{#346041}