Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: base/file_version_info.h

Issue 1306603003: Redefine CreateFileVersionInfoForCurrentModule() as a macro on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use a real macro Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app/client_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_FILE_VERSION_INFO_H_ 5 #ifndef BASE_FILE_VERSION_INFO_H_
6 #define BASE_FILE_VERSION_INFO_H_ 6 #define BASE_FILE_VERSION_INFO_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 #if defined(OS_WIN) 10 #if defined(OS_WIN)
(...skipping 14 matching lines...) Expand all
25 // Provides an interface for accessing the version information for a file. This 25 // Provides an interface for accessing the version information for a file. This
26 // is the information you access when you select a file in the Windows Explorer, 26 // is the information you access when you select a file in the Windows Explorer,
27 // right-click select Properties, then click the Version tab, and on the Mac 27 // right-click select Properties, then click the Version tab, and on the Mac
28 // when you select a file in the Finder and do a Get Info. 28 // when you select a file in the Finder and do a Get Info.
29 // 29 //
30 // This list of properties is straight out of Win32's VerQueryValue 30 // This list of properties is straight out of Win32's VerQueryValue
31 // <http://msdn.microsoft.com/en-us/library/ms647464.aspx> and the Mac 31 // <http://msdn.microsoft.com/en-us/library/ms647464.aspx> and the Mac
32 // version returns values from the Info.plist as appropriate. TODO(avi): make 32 // version returns values from the Info.plist as appropriate. TODO(avi): make
33 // this a less-obvious Windows-ism. 33 // this a less-obvious Windows-ism.
34 34
35 #if defined(OS_WIN)
36 // Creates a FileVersionInfo for the current module. Returns NULL in case of
37 // error. The returned object should be deleted when you are done with it. This
38 // is done as a macro to force inlining of __ImageBase. It used to be inside of
39 // a method labeled with __forceinline, but inlining through __forceinline
40 // stopped working for Debug builds in VS2013 (http://crbug.com/516359).
41 #define CREATE_FILE_VERSION_INFO_FOR_CURRENT_MODULE() \
42 FileVersionInfo::CreateFileVersionInfoForModule( \
43 reinterpret_cast<HMODULE>(&__ImageBase))
44 #endif
45
35 class BASE_EXPORT FileVersionInfo { 46 class BASE_EXPORT FileVersionInfo {
36 public: 47 public:
37 virtual ~FileVersionInfo() {} 48 virtual ~FileVersionInfo() {}
38 #if defined(OS_WIN) || defined(OS_MACOSX) 49 #if defined(OS_WIN) || defined(OS_MACOSX)
39 // Creates a FileVersionInfo for the specified path. Returns NULL if something 50 // Creates a FileVersionInfo for the specified path. Returns NULL if something
40 // goes wrong (typically the file does not exit or cannot be opened). The 51 // goes wrong (typically the file does not exit or cannot be opened). The
41 // returned object should be deleted when you are done with it. 52 // returned object should be deleted when you are done with it.
42 static FileVersionInfo* CreateFileVersionInfo( 53 static FileVersionInfo* CreateFileVersionInfo(
43 const base::FilePath& file_path); 54 const base::FilePath& file_path);
44 #endif // OS_WIN || OS_MACOSX 55 #endif // OS_WIN || OS_MACOSX
45 56
46 #if defined(OS_WIN) 57 #if defined(OS_WIN)
47 // Creates a FileVersionInfo for the specified module. Returns NULL in case 58 // Creates a FileVersionInfo for the specified module. Returns NULL in case
48 // of error. The returned object should be deleted when you are done with it. 59 // of error. The returned object should be deleted when you are done with it.
60 // See CREATE_FILE_VERSION_INFO_FOR_CURRENT_MODULE() helper above for a
61 // CreateFileVersionInfoForCurrentModule() alternative for Windows.
49 static FileVersionInfo* CreateFileVersionInfoForModule(HMODULE module); 62 static FileVersionInfo* CreateFileVersionInfoForModule(HMODULE module);
50
51 // Creates a FileVersionInfo for the current module. Returns NULL in case
52 // of error. The returned object should be deleted when you are done with it.
53 // This function should be inlined so that the "current module" is evaluated
54 // correctly, instead of being the module that contains base.
55 __forceinline static FileVersionInfo*
56 CreateFileVersionInfoForCurrentModule() {
57 HMODULE module = reinterpret_cast<HMODULE>(&__ImageBase);
58 return CreateFileVersionInfoForModule(module);
59 }
60 #else 63 #else
61 // Creates a FileVersionInfo for the current module. Returns NULL in case 64 // Creates a FileVersionInfo for the current module. Returns NULL in case
62 // of error. The returned object should be deleted when you are done with it. 65 // of error. The returned object should be deleted when you are done with it.
63 static FileVersionInfo* CreateFileVersionInfoForCurrentModule(); 66 static FileVersionInfo* CreateFileVersionInfoForCurrentModule();
64 #endif // OS_WIN 67 #endif // OS_WIN
65 68
66 // Accessors to the different version properties. 69 // Accessors to the different version properties.
67 // Returns an empty string if the property is not found. 70 // Returns an empty string if the property is not found.
68 virtual base::string16 company_name() = 0; 71 virtual base::string16 company_name() = 0;
69 virtual base::string16 company_short_name() = 0; 72 virtual base::string16 company_short_name() = 0;
70 virtual base::string16 product_name() = 0; 73 virtual base::string16 product_name() = 0;
71 virtual base::string16 product_short_name() = 0; 74 virtual base::string16 product_short_name() = 0;
72 virtual base::string16 internal_name() = 0; 75 virtual base::string16 internal_name() = 0;
73 virtual base::string16 product_version() = 0; 76 virtual base::string16 product_version() = 0;
74 virtual base::string16 private_build() = 0; 77 virtual base::string16 private_build() = 0;
75 virtual base::string16 special_build() = 0; 78 virtual base::string16 special_build() = 0;
76 virtual base::string16 comments() = 0; 79 virtual base::string16 comments() = 0;
77 virtual base::string16 original_filename() = 0; 80 virtual base::string16 original_filename() = 0;
78 virtual base::string16 file_description() = 0; 81 virtual base::string16 file_description() = 0;
79 virtual base::string16 file_version() = 0; 82 virtual base::string16 file_version() = 0;
80 virtual base::string16 legal_copyright() = 0; 83 virtual base::string16 legal_copyright() = 0;
81 virtual base::string16 legal_trademarks() = 0; 84 virtual base::string16 legal_trademarks() = 0;
82 virtual base::string16 last_change() = 0; 85 virtual base::string16 last_change() = 0;
83 virtual bool is_official_build() = 0; 86 virtual bool is_official_build() = 0;
84 }; 87 };
85 88
86 #endif // BASE_FILE_VERSION_INFO_H_ 89 #endif // BASE_FILE_VERSION_INFO_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/app/client_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698