cloud_print/common/win/install_utils.cc - Issue 1306603003: Redefine CreateFileVersionInfoForCurrentModule() as a macro on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/common/win/install_utils.cc

Issue 1306603003: Redefine CreateFileVersionInfoForCurrentModule() as a macro on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use a real macro Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cloud_print/common/win/install_utils.cc

diff --git a/cloud_print/common/win/install_utils.cc b/cloud_print/common/win/install_utils.cc

index eed09b3d36d1ad02dc7f423995052e3250c12993..b18d5fd5bbcf598671b5f50850eabfb62203d611 100644

--- a/cloud_print/common/win/install_utils.cc

+++ b/cloud_print/common/win/install_utils.cc

@@ -61,7 +61,7 @@ void SetGoogleUpdateKeys(const base::string16& product_id,

// Get the version from the resource file.

base::string16 version_string;

scoped_ptr<FileVersionInfo> version_info(

- FileVersionInfo::CreateFileVersionInfoForCurrentModule());

+ CREATE_FILE_VERSION_INFO_FOR_CURRENT_MODULE());

if (version_info.get()) {

FileVersionInfoWin* version_info_win =

@@ -152,7 +152,7 @@ void CreateUninstallKey(const base::string16& uninstall_id,

// Get the version resource.

scoped_ptr<FileVersionInfo> version_info(

- FileVersionInfo::CreateFileVersionInfoForCurrentModule());

+ CREATE_FILE_VERSION_INFO_FOR_CURRENT_MODULE());

if (version_info.get()) {

FileVersionInfoWin* version_info_win =

« no previous file with comments | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | cloud_print/virtual_driver/win/install/setup.cc » ('j') | no next file with comments »