Source/core/style/StyleGeneratedImage.cpp - Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/style/StyleGeneratedImage.cpp

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Ensure getComputedStyle returns absolute URLs Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/style/StyleGeneratedImage.cpp

diff --git a/Source/core/style/StyleGeneratedImage.cpp b/Source/core/style/StyleGeneratedImage.cpp

index fff63c74437c584b51b40ef7fedef448df0a4949..931556cf90b0535af5b189d9f5dcaa1ec5132355 100644

--- a/Source/core/style/StyleGeneratedImage.cpp

+++ b/Source/core/style/StyleGeneratedImage.cpp

@@ -42,6 +42,11 @@ PassRefPtrWillBeRawPtr<CSSValue> StyleGeneratedImage::cssValue() const

return m_imageGeneratorValue.get();

}

+PassRefPtrWillBeRawPtr<CSSValue> StyleGeneratedImage::computedCSSValue() const

+ return m_imageGeneratorValue ? m_imageGeneratorValue->valueWithAbsoluteURL() : nullptr;

Timothy Loh 2015/09/15 12:20:47 m_imageGeneratorValue looks non-null

nainar 2015/09/16 07:16:49 Done.

LayoutSize StyleGeneratedImage::imageSize(const LayoutObject* layoutObject, float multiplier) const

{

if (m_fixedSize) {

« Source/core/style/StyleFetchedImageSet.cpp ('K') | « Source/core/style/StyleGeneratedImage.h ('k') | Source/core/style/StyleImage.h » ('j') | Source/core/style/StylePendingImage.h » ('J')