Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: Source/core/style/StylePendingImage.h

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Ensure getComputedStyle returns absolute URLs Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/style/StylePendingImage.h
diff --git a/Source/core/style/StylePendingImage.h b/Source/core/style/StylePendingImage.h
index 8a00d6d36f786d8fdd979851fe9d1ced7cf48a69..b941a1b4a23114d5afb71834dde979e54b1364fb 100644
--- a/Source/core/style/StylePendingImage.h
+++ b/Source/core/style/StylePendingImage.h
@@ -49,6 +49,11 @@ public:
WrappedImagePtr data() const override { return m_value; }
PassRefPtrWillBeRawPtr<CSSValue> cssValue() const override { return m_value; }
+
+ PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const override
+ {
+ return (m_value && m_value->isImageValue()) ? toCSSImageValue(m_value)->valueWithAbsoluteURL() : nullptr;
Timothy Loh 2015/09/15 12:20:47 Does this function ever get reached?
nainar 2015/09/16 07:16:49 Removed.
+ }
CSSImageValue* cssImageValue() const { return m_value->isImageValue() ? toCSSImageValue(m_value) : 0; }
CSSImageGeneratorValue* cssImageGeneratorValue() const { return m_value->isImageGeneratorValue() ? toCSSImageGeneratorValue(m_value) : 0; }
CSSCursorImageValue* cssCursorImageValue() const { return m_value->isCursorImageValue() ? toCSSCursorImageValue(m_value) : 0; }
« Source/core/style/StyleGeneratedImage.cpp ('K') | « Source/core/style/StyleImage.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698