Source/core/style/StyleGeneratedImage.h - Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/style/StyleGeneratedImage.h

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Ensure getComputedStyle returns absolute URLs Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/style/StyleFetchedImageSet.cpp ('K') | « Source/core/style/StyleFetchedImageSet.cpp ('k') | Source/core/style/StyleGeneratedImage.cpp » ('j') | Source/core/style/StyleGeneratedImage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/style/StyleGeneratedImage.h

diff --git a/Source/core/style/StyleGeneratedImage.h b/Source/core/style/StyleGeneratedImage.h

index 8112e2d3ccdd271a2f2aaa680adc96033ca419f9..bc6ab42b82261d2abdee2b57f89c2d2ccf779401 100644

--- a/Source/core/style/StyleGeneratedImage.h

+++ b/Source/core/style/StyleGeneratedImage.h

@@ -42,6 +42,7 @@ public:

WrappedImagePtr data() const override { return m_imageGeneratorValue.get(); }

PassRefPtrWillBeRawPtr<CSSValue> cssValue() const override;

+ PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const override;

LayoutSize imageSize(const LayoutObject*, float multiplier) const override;

bool imageHasRelativeWidth() const override { return !m_fixedSize; }