Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: chrome/browser/android/popular_sites.h

Issue 1306043005: Popular sites on the NTP: store downloaded file at a fixed path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@redownload
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/most_visited_sites.cc ('k') | chrome/browser/android/popular_sites.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_POPULAR_SITES_H_ 5 #ifndef CHROME_BROWSER_ANDROID_POPULAR_SITES_H_
6 #define CHROME_BROWSER_ANDROID_POPULAR_SITES_H_ 6 #define CHROME_BROWSER_ANDROID_POPULAR_SITES_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 27 matching lines...) Expand all
38 ~Site(); 38 ~Site();
39 39
40 base::string16 title; 40 base::string16 title;
41 GURL url; 41 GURL url;
42 GURL favicon_url; 42 GURL favicon_url;
43 GURL thumbnail_url; 43 GURL thumbnail_url;
44 }; 44 };
45 45
46 using FinishedCallback = base::Callback<void(bool /* success */)>; 46 using FinishedCallback = base::Callback<void(bool /* success */)>;
47 47
48 // Usually, the name of the file that's downloaded is based on the user's
49 // locale. |filename|, if non-empty, will override that default name.
48 PopularSites(Profile* profile, 50 PopularSites(Profile* profile,
49 const std::string& filename, 51 const std::string& filename,
50 net::URLRequestContextGetter* request_context,
Marc Treib 2015/09/09 16:24:01 Unrelated: There's no need to pass this explicitly
51 const FinishedCallback& callback); 52 const FinishedCallback& callback);
52 ~PopularSites(); 53 ~PopularSites();
53 54
54 const std::vector<Site>& sites() const { return sites_; } 55 const std::vector<Site>& sites() const { return sites_; }
55 56
56 private: 57 private:
57 void OnDownloadDone(const base::FilePath& path, bool success); 58 void OnDownloadDone(const base::FilePath& path, bool success);
58 void OnJsonParsed(scoped_ptr<std::vector<Site>> sites); 59 void OnJsonParsed(scoped_ptr<std::vector<Site>> sites);
59 60
60 FinishedCallback callback_; 61 FinishedCallback callback_;
61 scoped_ptr<FileDownloader> downloader_; 62 scoped_ptr<FileDownloader> downloader_;
62 std::vector<Site> sites_; 63 std::vector<Site> sites_;
63 64
64 base::WeakPtrFactory<PopularSites> weak_ptr_factory_; 65 base::WeakPtrFactory<PopularSites> weak_ptr_factory_;
65 66
66 DISALLOW_COPY_AND_ASSIGN(PopularSites); 67 DISALLOW_COPY_AND_ASSIGN(PopularSites);
67 }; 68 };
68 69
69 #endif // CHROME_BROWSER_ANDROID_POPULAR_SITES_H_ 70 #endif // CHROME_BROWSER_ANDROID_POPULAR_SITES_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/most_visited_sites.cc ('k') | chrome/browser/android/popular_sites.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698