Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305963003: Introduce {next,previous}PositionOf() as replacement of {next,previous}() member functions in Positi (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, yoichio, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce {next,previous}PositionOf() as replacement of {next,previous}() member functions in PositionAlgorithm This patch introduces |{next,previous}PositionOf()| as replacement of |{next, previous}()| member function in |PositionAlgorithm| template class to simplify |PositionAlgorithm| class by isolating editing algorithm and representation of a position for improving code health. This patch also changes |PositionMoveType| as enum class and non-default parameter to clear intention of each call sites. Though, we may want to drop |CodePoint| movement. Following patch will move them to "EditingUtilities.{cpp,h}". BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200997

Patch Set 1 : 2015-08-21T15:25:59 #

Patch Set 2 : 2015-08-21T17:36:45 Rebase #

Patch Set 3 : 2015-08-22T00:12:04 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -52 lines) Patch
M Source/core/editing/EditingUtilities.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +9 lines, -4 lines 0 comments Download
M Source/core/editing/Position.h View 1 2 3 chunks +13 lines, -7 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 2 1 chunk +52 lines, -28 lines 0 comments Download
M Source/core/editing/PositionTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/editing/commands/ApplyBlockElementCommand.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/core/editing/commands/BreakBlockquoteCommand.cpp View 1 chunk +10 lines, -4 lines 0 comments Download
M Source/core/editing/commands/InsertTextCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/editing/commands/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/PendingSelection.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 32 (16 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-21 07:24:50 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-21 08:03:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305963003/1
5 years, 4 months ago (2015-08-21 08:11:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/91149)
5 years, 4 months ago (2015-08-21 08:15:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305963003/20001
5 years, 4 months ago (2015-08-21 08:37:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102241)
5 years, 4 months ago (2015-08-21 09:22:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305963003/20001
5 years, 4 months ago (2015-08-21 09:25:58 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/101761)
5 years, 4 months ago (2015-08-21 10:59:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305963003/20001
5 years, 4 months ago (2015-08-21 11:02:59 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58891)
5 years, 4 months ago (2015-08-21 14:38:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305963003/20001
5 years, 4 months ago (2015-08-21 14:45:11 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/91246)
5 years, 4 months ago (2015-08-21 14:49:44 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305963003/40001
5 years, 4 months ago (2015-08-21 15:12:51 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102356)
5 years, 4 months ago (2015-08-21 16:41:31 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305963003/40001
5 years, 4 months ago (2015-08-21 16:50:22 UTC) #31
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 18:22:22 UTC) #32
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200997

Powered by Google App Engine
This is Rietveld 408576698