Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: Source/core/editing/commands/InsertTextCommand.cpp

Issue 1305963003: Introduce {next,previous}PositionOf() as replacement of {next,previous}() member functions in Positi (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-22T00:12:04 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/commands/InsertTextCommand.cpp
diff --git a/Source/core/editing/commands/InsertTextCommand.cpp b/Source/core/editing/commands/InsertTextCommand.cpp
index 48476722a91e18aaf6f4aed7e80aebf8aac86803..e5d289914f1a60824d40f6c4d298d0665a4bff3b 100644
--- a/Source/core/editing/commands/InsertTextCommand.cpp
+++ b/Source/core/editing/commands/InsertTextCommand.cpp
@@ -186,7 +186,9 @@ void InsertTextCommand::doApply()
if (m_text == "\t") {
endPosition = insertTab(startPosition);
- startPosition = endPosition.previous();
+ // TODO(yosin) We should use |PositionMoveType::Character| for
+ // |previousPositionOf()|.
+ startPosition = previousPositionOf(endPosition, PositionMoveType::Character);
if (placeholder.isNotNull())
removePlaceholderAt(placeholder);
} else {
« no previous file with comments | « Source/core/editing/commands/BreakBlockquoteCommand.cpp ('k') | Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698