Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 13055002: Tab audio indicator tweaks (Closed)

Created:
7 years, 9 months ago by sail
Modified:
7 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, tfarina, sail+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Tab audio indicator tweaks Some small tweaks to the tab audio indicator: - change the icon to be half the size (4 bars instead of 8 bars) - draw 2 columns instead of 3 - draw the icon at the bottom right - clip the favicon so that it doesn't obscure the equalizers screenshot: http://i.imgur.com/csAXHDx.png BUG=3541 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191068

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -42 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac.mm View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/tabs/tab_audio_indicator.h View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/tab_audio_indicator.cc View 1 3 chunks +50 lines, -30 lines 0 comments Download
M chrome/browser/ui/tabs/tab_audio_indicator_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sail
7 years, 9 months ago (2013-03-25 02:43:28 UTC) #1
sail
Carlos, let me know what you think. I think we can change things some more. ...
7 years, 9 months ago (2013-03-25 02:43:49 UTC) #2
sail
Fixed Views issue. Please take a look. sky: chrome/browser/ui/* OWNERS cpu: audio indicator logic
7 years, 9 months ago (2013-03-25 23:55:37 UTC) #3
sky
LGTM
7 years, 9 months ago (2013-03-25 23:57:05 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
7 years, 9 months ago (2013-03-26 02:15:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/13055002/5001
7 years, 9 months ago (2013-03-27 18:30:56 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-28 00:03:01 UTC) #7
Message was sent while issue was closed.
Change committed as 191068

Powered by Google App Engine
This is Rietveld 408576698