Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: Source/core/css/Rect.h

Issue 1304993002: Change Rect and Quad to be CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_counter_out_attempt_3
Patch Set: Small change to generated style builder functions Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | Source/core/css/Rect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/Rect.h
diff --git a/Source/core/css/Rect.h b/Source/core/css/Rect.h
deleted file mode 100644
index d8190b1293709b31c36dd945e73712e1f670b8fe..0000000000000000000000000000000000000000
--- a/Source/core/css/Rect.h
+++ /dev/null
@@ -1,124 +0,0 @@
-/*
- * Copyright (C) 1999-2003 Lars Knoll (knoll@kde.org)
- * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef Rect_h
-#define Rect_h
-
-#include "core/CoreExport.h"
-#include "core/css/CSSPrimitiveValue.h"
-#include "wtf/RefPtr.h"
-#include "wtf/text/StringBuilder.h"
-
-namespace blink {
-
-class CORE_EXPORT RectBase : public RefCountedWillBeGarbageCollected<RectBase> {
- DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(RectBase);
-public:
- CSSPrimitiveValue* top() const { return m_top.get(); }
- CSSPrimitiveValue* right() const { return m_right.get(); }
- CSSPrimitiveValue* bottom() const { return m_bottom.get(); }
- CSSPrimitiveValue* left() const { return m_left.get(); }
-
- void setTop(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> top) { m_top = top; }
- void setRight(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> right) { m_right = right; }
- void setBottom(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> bottom) { m_bottom = bottom; }
- void setLeft(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> left) { m_left = left; }
-
- bool equals(const RectBase& other) const
- {
- return compareCSSValuePtr(m_top, other.m_top)
- && compareCSSValuePtr(m_right, other.m_right)
- && compareCSSValuePtr(m_left, other.m_left)
- && compareCSSValuePtr(m_bottom, other.m_bottom);
- }
-
- DECLARE_TRACE();
-
-protected:
- RectBase() { }
-
-private:
- RefPtrWillBeMember<CSSPrimitiveValue> m_top;
- RefPtrWillBeMember<CSSPrimitiveValue> m_right;
- RefPtrWillBeMember<CSSPrimitiveValue> m_bottom;
- RefPtrWillBeMember<CSSPrimitiveValue> m_left;
-};
-
-class Rect : public RectBase {
-public:
- static PassRefPtrWillBeRawPtr<Rect> create() { return adoptRefWillBeNoop(new Rect); }
-
- String cssText() const
- {
- return generateCSSString(top()->cssText(), right()->cssText(), bottom()->cssText(), left()->cssText());
- }
-
-private:
- Rect() { }
- static String generateCSSString(const String& top, const String& right, const String& bottom, const String& left)
- {
- return "rect(" + top + ' ' + right + ' ' + bottom + ' ' + left + ')';
- }
-
- // NOTE: If adding fields to this class please make the RectBase trace
- // method virtual and add a trace method in this subclass tracing the new
- // fields.
-};
-
-class Quad : public RectBase {
-public:
- static PassRefPtrWillBeRawPtr<Quad> create() { return adoptRefWillBeNoop(new Quad); }
-
- String cssText() const
- {
- return generateCSSString(top()->cssText(), right()->cssText(), bottom()->cssText(), left()->cssText());
- }
-
-private:
- Quad() { }
- static String generateCSSString(const String& top, const String& right, const String& bottom, const String& left)
- {
- StringBuilder result;
- // reserve space for the four strings, plus three space separator characters.
- result.reserveCapacity(top.length() + right.length() + bottom.length() + left.length() + 3);
- result.append(top);
- if (right != top || bottom != top || left != top) {
- result.append(' ');
- result.append(right);
- if (bottom != top || right != left) {
- result.append(' ');
- result.append(bottom);
- if (left != right) {
- result.append(' ');
- result.append(left);
- }
- }
- }
- return result.toString();
- }
-
- // NOTE: If adding fields to this class please make the RectBase trace
- // method virtual and add a trace method in this subclass tracing the new
- // fields.
-};
-
-} // namespace blink
-
-#endif // Rect_h
« no previous file with comments | « Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | Source/core/css/Rect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698