Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl - Issue 1304993002: Change Rect and Quad to be CSSValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 1304993002: Change Rect and Quad to be CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_counter_out_attempt_3

Patch Set: Small change to generated style builder functions Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

diff --git a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

index 82db206ba9a93ecbe56116f4f7f42fbd081732cf..9a5ae7d2e0a483716fe2969f84ef4a5ab8a0fec8 100644

--- a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

+++ b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

@@ -139,8 +139,7 @@ namespace blink {

{

- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

- if (primitiveValue->getValueID() == {{auto_identity}})

+ if (value->isPrimitiveValue() && toCSSPrimitiveValue(value)->getValueID() == {{auto_identity}})

state.style()->{{auto_setter}}();

else

« no previous file with comments | « no previous file | Source/core/animation/DeferredLegacyStyleInterpolation.h » ('j') | no next file with comments »