Issue 1304873006: [heap] Enforce coding style decl order in {Heap} round #3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1304873006: [heap] Enforce coding style decl order in {Heap} round #3. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger

Modified:
5 years, 4 months ago

Reviewers:
Michael Lippautz

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-heap-store-buffer-api

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[heap] Enforce coding style decl order in {Heap} round #3. R=mlippautz@chromium.org Committed: https://crrev.com/d6f224f48aa5af63ba4bec8a079b512ca18957a0 Cr-Commit-Position: refs/heads/master@{#30358}

Patch Set 1 #

Patch Set 2 : Rebased. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -69 lines)			Patch
	M	src/heap/heap.h	View	1	6 chunks	+73 lines, -69 lines	0 comments	Download

Depends on Patchset:

Issue 1317553002 Patch 20001

Dependent Patchsets:

Issue 1312553003 Patch 1

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304873006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304873006/20001

5 years, 4 months ago (2015-08-25 15:15:28 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-25 15:17:00 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/d6f224f48aa5af63ba4bec8a079b512ca18957a0
Cr-Commit-Position: refs/heads/master@{#30358}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages