Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317553002: [heap] Prevent direct access to StoreBuffer. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Prevent direct access to StoreBuffer. R=mlippautz@chromium.org Committed: https://crrev.com/38b9beb8e9b38a7cc36abb337ca2cd73be412708 Cr-Commit-Position: refs/heads/master@{#30355}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -39 lines) Patch
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 8 chunks +20 lines, -19 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/heap/store-buffer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/store-buffer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/store-buffer-inl.h View 1 chunk +1 line, -6 lines 0 comments Download

Dependent Patchsets:

Issue 1304873006 Patch 20001

Messages

Total messages: 11 (4 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-25 10:40:05 UTC) #1
Michael Lippautz
lgtm
5 years, 3 months ago (2015-08-25 12:23:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317553002/1
5 years, 3 months ago (2015-08-25 12:32:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5193)
5 years, 3 months ago (2015-08-25 12:33:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317553002/20001
5 years, 3 months ago (2015-08-25 13:08:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-25 13:38:49 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 13:39:02 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/38b9beb8e9b38a7cc36abb337ca2cd73be412708
Cr-Commit-Position: refs/heads/master@{#30355}

Powered by Google App Engine
This is Rietveld 408576698