[heap] Prevent direct access to ExternalStringTable.

[heap] Prevent direct access to ExternalStringTable.

R=mlippautz@chromium.org

Committed: https://crrev.com/b1c5ff0fff6c2df4ed2dcbcf162cfb6e45e40da4
Cr-Commit-Position: refs/heads/master@{#30372}

[Michael Starzinger, 2015-08-25 14:18:31]

https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1349
src/heap/heap.h:1349: inline void AddExternalString(String* string);
Wasn't sure whether "AddExternalString" or "RegisterExternalString" would be a
better name for this. WDYT? Happy to change it.

[Michael Lippautz, 2015-08-25 17:23:37]

lgtm

https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1349
src/heap/heap.h:1349: inline void AddExternalString(String* string);
On 2015/08/25 14:18:30, Michael Starzinger wrote:
> Wasn't sure whether "AddExternalString" or "RegisterExternalString" would be a
> better name for this. WDYT? Happy to change it.

We already have a couple of Register*() methods. Let's rename it.

https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1596
src/heap/heap.h:1596: friend class Heap;
Move to bottom.

[Michael Starzinger, 2015-08-26 08:39:57]

Addressed comments. Thanks for review. Landing.

https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1349
src/heap/heap.h:1349: inline void AddExternalString(String* string);
On 2015/08/25 17:23:37, Michael Lippautz wrote:
> On 2015/08/25 14:18:30, Michael Starzinger wrote:
> > Wasn't sure whether "AddExternalString" or "RegisterExternalString" would be
a
> > better name for this. WDYT? Happy to change it.
> 
> We already have a couple of Register*() methods. Let's rename it.

Done.

https://codereview.chromium.org/1312553003/diff/1/src/heap/heap.h#newcode1596
src/heap/heap.h:1596: friend class Heap;
On 2015/08/25 17:23:37, Michael Lippautz wrote:
> Move to bottom.

Done.

[Michael Starzinger, 2015-08-26 09:22:18]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-08-26 09:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1312553003/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-08-26 09:22:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312553003/40001

[commit-bot: I haz the power, 2015-08-26 09:35:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-26 09:35:59]

Patchset 3 (id:??) landed as
https://crrev.com/b1c5ff0fff6c2df4ed2dcbcf162cfb6e45e40da4
Cr-Commit-Position: refs/heads/master@{#30372}