Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 1304363008: [Editing][CodeHealth] remove default argument 'host' in EditingTestBase::setShadowContent (Closed)

Created:
5 years, 3 months ago by yoichio
Modified:
5 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Editing][CodeHealth] remove default argument 'host' in EditingTestBase::setShadowContent It is hard to understand setShadowContent puts content to a 'host' ID element. Let's call explicitly. BUG= TEST=<no behavior changes> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201460

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M Source/core/editing/EditingStrategyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingTestBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingUtilitiesTest.cpp View 1 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/PositionTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/VisiblePositionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleSelectionTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/serializers/StyledMarkupSerializerTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
yoichio
5 years, 3 months ago (2015-08-28 06:35:30 UTC) #2
yosin_UTC9
lgtm I guess original code has hard coded "host".
5 years, 3 months ago (2015-08-28 06:46:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304363008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304363008/1
5 years, 3 months ago (2015-08-28 07:07:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304363008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304363008/1
5 years, 3 months ago (2015-08-28 07:08:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99946)
5 years, 3 months ago (2015-08-28 08:26:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304363008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304363008/20001
5 years, 3 months ago (2015-08-31 02:02:14 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 02:50:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201460

Powered by Google App Engine
This is Rietveld 408576698