Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: Source/core/editing/serializers/StyledMarkupSerializerTest.cpp

Issue 1304363008: [Editing][CodeHealth] remove default argument 'host' in EditingTestBase::setShadowContent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisibleUnitsTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
diff --git a/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp b/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
index d2659f2664114c261cc4d4414c173af914ff2d1e..fbf4340cdd6c20c25a664cf115554a13006f11e8 100644
--- a/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
+++ b/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
@@ -117,7 +117,7 @@ TEST_F(StyledMarkupSerializerTest, ShadowTreeDistributeOrder)
const char* bodyContent = "<p id=\"host\">00<b id=\"one\">11</b><b id=\"two\">22</b>33</p>";
const char* shadowContent = "<a><content select=#two></content><content select=#one></content></a>";
setBodyContent(bodyContent);
- setShadowContent(shadowContent);
+ setShadowContent(shadowContent, "host");
EXPECT_EQ("<p id=\"host\"><b id=\"one\">11</b><b id=\"two\">22</b></p>", serialize<EditingStrategy>())
<< "00 and 33 aren't appeared since they aren't distributed.";
EXPECT_EQ("<p id=\"host\"><a><b id=\"two\">22</b><b id=\"one\">11</b></a></p>", serialize<EditingInComposedTreeStrategy>())
@@ -129,7 +129,7 @@ TEST_F(StyledMarkupSerializerTest, ShadowTreeInput)
const char* bodyContent = "<p id=\"host\">00<b id=\"one\">11</b><b id=\"two\"><input value=\"22\"></b>33</p>";
const char* shadowContent = "<a><content select=#two></content><content select=#one></content></a>";
setBodyContent(bodyContent);
- setShadowContent(shadowContent);
+ setShadowContent(shadowContent, "host");
EXPECT_EQ("<p id=\"host\"><b id=\"one\">11</b><b id=\"two\"><input value=\"22\"></b></p>", serialize<EditingStrategy>())
<< "00 and 33 aren't appeared since they aren't distributed.";
EXPECT_EQ("<p id=\"host\"><a><b id=\"two\"><input value=\"22\"></b><b id=\"one\">11</b></a></p>", serialize<EditingInComposedTreeStrategy>())
@@ -142,7 +142,7 @@ TEST_F(StyledMarkupSerializerTest, ShadowTreeNested)
const char* shadowContent1 = "<a><content select=#two></content><b id=host2></b><content select=#one></content></a>";
const char* shadowContent2 = "NESTED";
setBodyContent(bodyContent);
- RefPtrWillBeRawPtr<ShadowRoot> shadowRoot1 = setShadowContent(shadowContent1);
+ RefPtrWillBeRawPtr<ShadowRoot> shadowRoot1 = setShadowContent(shadowContent1, "host");
createShadowRootForElementWithIDAndSetInnerHTML(*shadowRoot1, "host2", shadowContent2);
EXPECT_EQ("<p id=\"host\"><b id=\"one\">11</b><b id=\"two\">22</b></p>", serialize<EditingStrategy>())
@@ -181,7 +181,7 @@ TEST_F(StyledMarkupSerializerTest, ShadowTreeStyle)
bodyContent = "<p id='host' style='color: red'>00<span id='one'>11</span>22</p>\n";
const char* shadowContent = "<span style='font-weight: bold'><content select=#one></content></span>";
setBodyContent(bodyContent);
- setShadowContent(shadowContent);
+ setShadowContent(shadowContent, "host");
one = document().getElementById("one");
text = toText(one->firstChild());
PositionInComposedTree startICT(text, 0);
« no previous file with comments | « Source/core/editing/VisibleUnitsTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698