Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: Source/core/editing/VisibleUnitsTest.cpp

Issue 1304363008: [Editing][CodeHealth] remove default argument 'host' in EditingTestBase::setShadowContent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/VisibleUnitsTest.cpp
diff --git a/Source/core/editing/VisibleUnitsTest.cpp b/Source/core/editing/VisibleUnitsTest.cpp
index 107baf8816b205c3fff528778622fb58332f8ec3..58f4b284079f9c26926828f8ab1bbf53cc9c4e85 100644
--- a/Source/core/editing/VisibleUnitsTest.cpp
+++ b/Source/core/editing/VisibleUnitsTest.cpp
@@ -32,7 +32,7 @@ TEST_F(VisibleUnitsTest, inSameLine)
const char* bodyContent = "<p id='host'>00<b id='one'>11</b><b id='two'>22</b>33</p>";
const char* shadowContent = "<div><span id='s4'>44</span><content select=#two></content><br><span id='s5'>55</span><br><content select=#one></content><span id='s6'>66</span></div>";
setBodyContent(bodyContent);
- RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent);
+ RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent, "host");
updateLayoutAndStyleForPainting();
RefPtrWillBeRawPtr<Element> body = document().body();
@@ -57,7 +57,7 @@ TEST_F(VisibleUnitsTest, localCaretRectOfPosition)
const char* bodyContent = "<p id='host'><b id='one'>1</b></p><b id='two'>22</b>";
const char* shadowContent = "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
setBodyContent(bodyContent);
- setShadowContent(shadowContent);
+ setShadowContent(shadowContent, "host");
updateLayoutAndStyleForPainting();
RefPtrWillBeRawPtr<Element> one = document().getElementById("one");
@@ -79,7 +79,7 @@ TEST_F(VisibleUnitsTest, mostBackwardCaretPositionAfterAnchor)
const char* bodyContent = "<p id='host'><b id='one'>1</b></p><b id='two'>22</b>";
const char* shadowContent = "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
setBodyContent(bodyContent);
- setShadowContent(shadowContent);
+ setShadowContent(shadowContent, "host");
updateLayoutAndStyleForPainting();
RefPtrWillBeRawPtr<Element> host = document().getElementById("host");
@@ -93,7 +93,7 @@ TEST_F(VisibleUnitsTest, mostForwardCaretPositionAfterAnchor)
const char* bodyContent = "<p id='host'><b id='one'>1</b></p>";
const char* shadowContent = "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
setBodyContent(bodyContent);
- RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent);
+ RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent, "host");
updateLayoutAndStyleForPainting();
RefPtrWillBeRawPtr<Element> host = document().getElementById("host");
« no previous file with comments | « Source/core/editing/VisibleSelectionTest.cpp ('k') | Source/core/editing/serializers/StyledMarkupSerializerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698