Issue 1304123006: Applying the "all" property needs to check all properties against the whitelist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1304123006: Applying the "all" property needs to check all properties against the whitelist. (Closed)

Created:
5 years, 3 months ago by mstensho (USE GERRIT)

Modified:
5 years, 3 months ago

Reviewers:
rune

CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, mstensho (USE GERRIT), rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Applying the "all" property needs to check all properties against the whitelist. When applying any other property than "all", we already perform this whitelist check, but applying "all" is a separate code path, and the checks were missing there. BUG=524682 R=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201315

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -8 lines)			Patch
A	LayoutTests/fast/css/all-shorthand-first-letter.html	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/all-shorthand-first-letter-expected.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/pagination/first-letter-inherit-all-crash.html	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/pagination/first-letter-inherit-all-crash-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	4 chunks	+22 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304123006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304123006/1

5 years, 3 months ago (2015-08-27 13:27:57 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-08-27 14:34:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201315

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages