LayoutTests/fast/pagination/first-letter-inherit-all-crash.html - Issue 1304123006: Applying the "all" property needs to check all properties against the whitelist.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/pagination/first-letter-inherit-all-crash.html

Issue 1304123006: Applying the "all" property needs to check all properties against the whitelist. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/css/all-shorthand-first-letter-expected.html ('k') | LayoutTests/fast/pagination/first-letter-inherit-all-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #elm { overflow-y:-webkit-paged-y; }

	4

	5 /* Need to float the first letter, to turn it into a block. Otherwise, overf low-y wouldn't be

	6 an applicable property in the first place. */

	7 #elm::first-letter { all:inherit; float:left; }

	8 </style>

	9 <p>overflow-y isn't a valid property for ::first-letter. We'd crash when extract ing innerText,

	10 because the implementation expects that the first letter text is a direct ch ild of the

	11 ::first-letter pseudo object. The paged overflow / multicol implementation w ould violate this

	12 assumption by inserting a flow thread object between the ::first-letter pseu do object and the

	13 actual text.</p>

	14 <p>PASS if no crash or assertion failure.</p>

	15 <div id="elm">x</div>

	16 <script>

	17 if (window.testRunner)

	18 testRunner.dumpAsText();

	19 document.getElementById("elm").innerText;

	20 </script>

OLD	NEW