LayoutTests/fast/pagination/first-letter-inherit-all-crash-expected.txt - Issue 1304123006: Applying the "all" property needs to check all properties against the whitelist.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/pagination/first-letter-inherit-all-crash-expected.txt

Issue 1304123006: Applying the "all" property needs to check all properties against the whitelist. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 overflow-y isn't a valid property for ::first-letter. We'd crash when extracting innerText, because the implementation expects that the first letter text is a d irect child of the ::first-letter pseudo object. The paged overflow / multicol i mplementation would violate this assumption by inserting a flow thread object be tween the ::first-letter pseudo object and the actual text.

	2

	3 PASS if no crash or assertion failure.

	4

	5 x

OLD	NEW

« no previous file with comments | « LayoutTests/fast/pagination/first-letter-inherit-all-crash.html ('k') | Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »