Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1304103005: Revert of gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM. (Closed)

Created:
5 years, 3 months ago by Jamie Madill
Modified:
5 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM. (patchset #10 id:200001 of https://codereview.chromium.org/1275773003/ ) Reason for revert: Linux AMD GPU FYI bot has a broken gl_tests, likely because of this patch. http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/41273 [ RUN ] GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.Basic/2 Received signal 11 SEGV_MAPERR 000000000045 #0 0x000000492795 base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7ff52630acb0 <unknown> #2 0x7ff5232a858c <unknown> #3 0x7ff5230a247c <unknown> #4 0x7ff5230a33ae <unknown> #5 0x7ff5227e8585 <unknown> #6 0x7ff5227e9b0a <unknown> #7 0x7ff522bf75c3 <unknown> #8 0x0000004f7ba4 gfx::GLApiBase::glCopyTexImage2DFn() #9 0x000000596ac1 (anonymous namespace)::DoCopyTexImage2D() #10 0x0000005968c4 gpu::CopyTextureCHROMIUMResourceManager::DoCopyTexture() Original issue's description: > gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM. > > It makes it possible to optimize WebGL. > > TEST=gl_tests GLCopyTextureCHROMIUMTests/GLCopyTextureCHROMIUMTest.* > BUG=517548 > > Committed: https://crrev.com/fa25f0e5786527e63c6ff9aeda77da3bd7456ee3 > Cr-Commit-Position: refs/heads/master@{#347354} TBR=piman@chromium.org,sievers@chromium.org,kbr@chromium.org,zmo@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517548, 528374 Committed: https://crrev.com/8ff8391503975e2559bf14e544b6aa469f612d25 Cr-Commit-Position: refs/heads/master@{#347465}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -499 lines) Patch
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt View 1 3 chunks +3 lines, -13 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 1 chunk +0 lines, -21 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h View 1 4 chunks +12 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 13 chunks +43 lines, -128 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 17 chunks +72 lines, -73 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 1 27 chunks +112 lines, -231 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Jamie Madill
Created Revert of gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM.
5 years, 3 months ago (2015-09-04 18:27:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304103005/1
5 years, 3 months ago (2015-09-04 18:28:14 UTC) #2
commit-bot: I haz the power
Failed to commit the patch.
5 years, 3 months ago (2015-09-04 18:29:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304103005/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304103005/200001
5 years, 3 months ago (2015-09-04 19:07:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:200001)
5 years, 3 months ago (2015-09-04 19:08:49 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8ff8391503975e2559bf14e544b6aa469f612d25 Cr-Commit-Position: refs/heads/master@{#347465}
5 years, 3 months ago (2015-09-04 19:09:45 UTC) #9
dshwang
5 years, 2 months ago (2015-09-28 11:14:53 UTC) #10
Message was sent while issue was closed.
On 2015/09/04 19:09:45, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/8ff8391503975e2559bf14e544b6aa469f612d25
> Cr-Commit-Position: refs/heads/master@{#347465}

thx for reverting. Let me re-land with ATI handling.

Powered by Google App Engine
This is Rietveld 408576698