Create module system for VisualBench

Create module system for VisualBench

The newly created VisualLightweightBenchModule is just the old VisualBench.cpp, but gutted to only include timing code.

Future CLs will harden this abstraction, but for this CL the module owns a backpointer to VisualBench.cpp for a couple of calls.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/189aef7834e20a01c062817b54a49b76ad4a0b4b

[joshualitt, 2015-09-04 17:23:25]

joshualitt@google.com changed reviewers:
+ egdaniel@google.com, jvanverth@google.com

[joshualitt, 2015-09-04 17:24:20]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-09-04 17:24:20]

This CL just moves a bunch of code around to decouple the lightweight timing in
visual bench from the visual bench 'driver' program.  In the next CL I'll try to
get rid of the backpointer between VLBM and VB

[jvanverth1, 2015-09-04 18:25:36]

Not sure I know enough about VisualBench yet to provide good comments, but it
looks okay. One general comment and one specific one:

It wasn't initially clear to me that you'd taken VisualBench.{cpp,h}, copied it
to VisualBenchFlags and VisualBenchLightweightBenchModule, and then stripped out
the redundant parts of each. It might help to add that to the description.

https://codereview.chromium.org/1304083007/diff/20001/gyp/visualbench.gyp
File gyp/visualbench.gyp (right):

https://codereview.chromium.org/1304083007/diff/20001/gyp/visualbench.gyp#new...
gyp/visualbench.gyp:27: '<!@(python find.py ../tools/VisualBench "*.cpp")',
No .h files?

[joshualitt, 2015-09-04 20:34:00]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[joshualitt, 2015-09-04 20:34:08]

feedback incorporated

[robertphillips, 2015-09-08 12:38:06]

I'm in the same boat as Jim - it looks fine to me but I don't really know the
code.

https://codereview.chromium.org/1304083007/diff/40001/tools/VisualBench/Visua...
File tools/VisualBench/VisualLightweightBenchModule.h (right):

https://codereview.chromium.org/1304083007/diff/40001/tools/VisualBench/Visua...
tools/VisualBench/VisualLightweightBenchModule.h:22: /*
New comment ?

https://codereview.chromium.org/1304083007/diff/40001/tools/VisualBench/Visua...
File tools/VisualBench/VisualModule.h (right):

https://codereview.chromium.org/1304083007/diff/40001/tools/VisualBench/Visua...
tools/VisualBench/VisualModule.h:14: class SkCanvas;
Do we need SkSurface ?

https://codereview.chromium.org/1304083007/diff/40001/tools/VisualBench/Visua...
tools/VisualBench/VisualModule.h:16: 
// This guy exists for some reason ...

?

https://codereview.chromium.org/1304083007/diff/40001/tools/VisualBench/Visua...
tools/VisualBench/VisualModule.h:21: virtual void draw(SkCanvas* canvas)=0;
private:
  typedef SkRefCnt INHERITED;

?

[robertphillips, 2015-09-08 13:51:52]

lgtm

[joshualitt, 2015-09-08 14:01:41]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-09-08 14:01:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1304083007/#ps60001
(title: "feedback inc")

[commit-bot: I haz the power, 2015-09-08 14:01:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304083007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304083007/60001

[commit-bot: I haz the power, 2015-09-08 14:08:14]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/189aef7834e20a01c062817b54a49b76ad4a0b4b