Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1304063002: Move isVisuallyEquivalentCandidate() to VisibleUnits.{cpp,h} from Position.{cpp,h} (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move isVisuallyEquivalentCandidate() to VisibleUnits.{cpp,h} from Position.{cpp,h} This patch moves |isVisuallyEquivalentCandidate()| to "VisibleUnits.{cpp,h} from "Position.{cpp,h}" to consolidate |InlineBox| dependency to "VisibleUnits.cpp" for ease of working them later. This patch also gets rid of unused include directives from "Position.cpp". BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200971

Patch Set 1 : 2015-08-21T14:13:20 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -107 lines) Patch
M Source/core/editing/Position.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/editing/Position.cpp View 4 chunks +0 lines, -102 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +90 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-21 06:01:08 UTC) #2
yoichio
lgtm
5 years, 4 months ago (2015-08-21 06:57:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304063002/1
5 years, 4 months ago (2015-08-21 07:24:55 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 07:29:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200971

Powered by Google App Engine
This is Rietveld 408576698