Source/core/editing/Position.h - Issue 1304063002: Move isVisuallyEquivalentCandidate() to VisibleUnits.{cpp,h} from Position.{cpp,h}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Position.h

Issue 1304063002: Move isVisuallyEquivalentCandidate() to VisibleUnits.{cpp,h} from Position.{cpp,h} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-21T14:13:20 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/Position.h

diff --git a/Source/core/editing/Position.h b/Source/core/editing/Position.h

index 6aa73a495a5194e87d2d23ca466b116a28cf3a96..2a8331ddd80bcc2499a2503929dc6dad12727af3 100644

--- a/Source/core/editing/Position.h

+++ b/Source/core/editing/Position.h

@@ -442,11 +442,6 @@ CORE_EXPORT bool inRenderedText(const PositionInComposedTree&);

CORE_EXPORT int uncheckedPreviousOffset(const Node*, int current);

CORE_EXPORT int uncheckedNextOffset(const Node*, int current);

-// TODO(yosin) We should move |isVisuallyEquivalentCandidate()| to

-// "VisibleUnits.cpp" to reduce |LayoutObject| dependency in "Position.cpp".

-CORE_EXPORT bool isVisuallyEquivalentCandidate(const Position&);

-CORE_EXPORT bool isVisuallyEquivalentCandidate(const PositionInComposedTree&);

} // namespace blink

#ifndef NDEBUG

« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »