Make classes and structures in core/loader fast-allocated.

Make classes and structures in core/loader fast-allocated.

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201383

[tasak, 2015-08-27 04:15:51]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[tasak, 2015-08-27 04:15:51]

Would you review this CL?

[haraken, 2015-08-27 05:44:49]

LGTM

https://codereview.chromium.org/1304043006/diff/20001/Source/core/loader/Empt...
File Source/core/loader/EmptyClients.h (right):

https://codereview.chromium.org/1304043006/diff/20001/Source/core/loader/Empt...
Source/core/loader/EmptyClients.h:266: DISALLOW_ALLOCATION();

Don't we want to add this to the parent class?

[tasak, 2015-08-27 07:50:48]

Thank you for review.

https://codereview.chromium.org/1304043006/diff/20001/Source/core/loader/Empt...
File Source/core/loader/EmptyClients.h (right):

https://codereview.chromium.org/1304043006/diff/20001/Source/core/loader/Empt...
Source/core/loader/EmptyClients.h:266: DISALLOW_ALLOCATION();
On 2015/08/27 05:44:48, haraken wrote:
> 
> Don't we want to add this to the parent class?

Looking at only EmptyTextCheckerClient, it sounds ok. However, looking at
another subclass of TextCheckerClient, i.e. SpellCheckerClientImpl:

  class  SpellCheckerClientImpl final : public SpellCheckerClient, public
TextCheckerClient { ... }

SpellCheckerClientImpl is a subclass of both SpellCheckerClient and
TextCheckerClient.
TextCheckerClient and SpellCheckerClient work in the almost the same way (i.e.
(just defining interfaces).

I'm not sure which class should be DISALLOW_ALLOCATION.
We need DISALLOW_ALLOCATION_MIXIN?

[haraken, 2015-08-27 09:04:25]

On 2015/08/27 07:50:48, tasak wrote:
> Thank you for review.
> 
>
https://codereview.chromium.org/1304043006/diff/20001/Source/core/loader/Empt...
> File Source/core/loader/EmptyClients.h (right):
> 
>
https://codereview.chromium.org/1304043006/diff/20001/Source/core/loader/Empt...
> Source/core/loader/EmptyClients.h:266: DISALLOW_ALLOCATION();
> On 2015/08/27 05:44:48, haraken wrote:
> > 
> > Don't we want to add this to the parent class?
> 
> Looking at only EmptyTextCheckerClient, it sounds ok. However, looking at
> another subclass of TextCheckerClient, i.e. SpellCheckerClientImpl:
> 
>   class  SpellCheckerClientImpl final : public SpellCheckerClient, public
> TextCheckerClient { ... }
> 
> SpellCheckerClientImpl is a subclass of both SpellCheckerClient and
> TextCheckerClient.
> TextCheckerClient and SpellCheckerClient work in the almost the same way (i.e.
> (just defining interfaces).
> 
> I'm not sure which class should be DISALLOW_ALLOCATION.
> We need DISALLOW_ALLOCATION_MIXIN?

Understood. To avoid unnecessary complexity like DISALLOW_ALLOCATION_MIXIN,
let's go with the current approach.

LGTM.

[tasak, 2015-08-28 07:17:44]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2015-08-28 07:17:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304043006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304043006/20001

[commit-bot: I haz the power, 2015-08-28 08:42:09]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201383