Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: Source/core/loader/EmptyClients.h

Issue 1304043006: Make classes and structures in core/loader fast-allocated. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/loader/DocumentLoader.h ('k') | Source/core/loader/FormSubmission.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org) 2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org)
3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 PassOwnPtr<WebServiceWorkerProvider> createServiceWorkerProvider() override; 256 PassOwnPtr<WebServiceWorkerProvider> createServiceWorkerProvider() override;
257 bool isControlledByServiceWorker(DocumentLoader&) override { return false; } 257 bool isControlledByServiceWorker(DocumentLoader&) override { return false; }
258 int64_t serviceWorkerID(DocumentLoader&) override { return -1; } 258 int64_t serviceWorkerID(DocumentLoader&) override { return -1; }
259 PassOwnPtr<WebApplicationCacheHost> createApplicationCacheHost(WebApplicatio nCacheHostClient*) override; 259 PassOwnPtr<WebApplicationCacheHost> createApplicationCacheHost(WebApplicatio nCacheHostClient*) override;
260 260
261 protected: 261 protected:
262 EmptyFrameLoaderClient() {} 262 EmptyFrameLoaderClient() {}
263 }; 263 };
264 264
265 class CORE_EXPORT EmptyTextCheckerClient : public TextCheckerClient { 265 class CORE_EXPORT EmptyTextCheckerClient : public TextCheckerClient {
266 DISALLOW_ALLOCATION();
haraken 2015/08/27 05:44:48 Don't we want to add this to the parent class?
tasak 2015/08/27 07:50:48 Looking at only EmptyTextCheckerClient, it sounds
266 public: 267 public:
267 ~EmptyTextCheckerClient() { } 268 ~EmptyTextCheckerClient() { }
268 269
269 bool shouldEraseMarkersAfterChangeSelection(TextCheckingType) const override { return true; } 270 bool shouldEraseMarkersAfterChangeSelection(TextCheckingType) const override { return true; }
270 void checkSpellingOfString(const String&, int*, int*) override {} 271 void checkSpellingOfString(const String&, int*, int*) override {}
271 String getAutoCorrectSuggestionForMisspelledWord(const String&) override { r eturn String(); } 272 String getAutoCorrectSuggestionForMisspelledWord(const String&) override { r eturn String(); }
272 void checkGrammarOfString(const String&, Vector<GrammarDetail>&, int*, int*) override {} 273 void checkGrammarOfString(const String&, Vector<GrammarDetail>&, int*, int*) override {}
273 void requestCheckingOfString(PassRefPtrWillBeRawPtr<TextCheckingRequest>) ov erride; 274 void requestCheckingOfString(PassRefPtrWillBeRawPtr<TextCheckingRequest>) ov erride;
274 }; 275 };
275 276
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 ~EmptyDragClient() override {} 325 ~EmptyDragClient() override {}
325 DragDestinationAction actionMaskForDrag(DragData*) override { return DragDes tinationActionNone; } 326 DragDestinationAction actionMaskForDrag(DragData*) override { return DragDes tinationActionNone; }
326 void startDrag(DragImage*, const IntPoint&, const IntPoint&, DataTransfer*, LocalFrame*, bool) override {} 327 void startDrag(DragImage*, const IntPoint&, const IntPoint&, DataTransfer*, LocalFrame*, bool) override {}
327 }; 328 };
328 329
329 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&); 330 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&);
330 331
331 } // namespace blink 332 } // namespace blink
332 333
333 #endif // EmptyClients_h 334 #endif // EmptyClients_h
OLDNEW
« no previous file with comments | « Source/core/loader/DocumentLoader.h ('k') | Source/core/loader/FormSubmission.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698