Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303993006: MD Downloads: compute description and tag via data binding (Closed)

Created:
5 years, 3 months ago by Dan Beam
Modified:
5 years, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dom-if5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: compute description and tag via data binding R=tommycli@chromium.org BUG=526577 Committed: https://crrev.com/de5f49cbfd72603660fa4315e7b17b8bcc6f242e Cr-Commit-Position: refs/heads/master@{#348067}

Patch Set 1 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -70 lines) Patch
M chrome/browser/resources/md_downloads/item.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 3 chunks +40 lines, -58 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 5 chunks +12 lines, -10 lines 0 comments Download

Depends on Patchset:

Issue 1305063012 Patch 1

Messages

Total messages: 8 (2 generated)
Dan Beam
5 years, 3 months ago (2015-09-09 01:21:12 UTC) #2
tommycli
lgtm
5 years, 3 months ago (2015-09-09 21:03:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303993006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303993006/20001
5 years, 3 months ago (2015-09-10 00:07:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-09-10 01:31:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/de5f49cbfd72603660fa4315e7b17b8bcc6f242e Cr-Commit-Position: refs/heads/master@{#348067}
5 years, 3 months ago (2015-09-10 01:32:08 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:09 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/de5f49cbfd72603660fa4315e7b17b8bcc6f242e
Cr-Commit-Position: refs/heads/master@{#348067}

Powered by Google App Engine
This is Rietveld 408576698