Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305063012: MD Downloads: compute content classes via data binding (Closed)

Created:
5 years, 3 months ago by Dan Beam
Modified:
5 years, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dom-if4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: compute content classes via data binding Also use dom-if to remove a bunch of dangerous nodes BUG=526577 R=tommycli@chromium.org Committed: https://crrev.com/bfce100feb02dd46deab8a920f14d80ab1327ea8 Cr-Commit-Position: refs/heads/master@{#348040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -22 lines) Patch
M chrome/browser/resources/md_downloads/item.html View 2 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 2 chunks +16 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1331573003 Patch 20001

Dependent Patchsets:

Issue 1303993006 Patch 20001

Messages

Total messages: 11 (3 generated)
Dan Beam
5 years, 3 months ago (2015-09-09 00:40:57 UTC) #1
tommycli
lgtm
5 years, 3 months ago (2015-09-09 21:04:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305063012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305063012/1
5 years, 3 months ago (2015-09-09 21:33:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/101910)
5 years, 3 months ago (2015-09-09 22:38:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305063012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305063012/1
5 years, 3 months ago (2015-09-09 22:46:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 23:57:21 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bfce100feb02dd46deab8a920f14d80ab1327ea8 Cr-Commit-Position: refs/heads/master@{#348040}
5 years, 3 months ago (2015-09-09 23:57:59 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:04:54 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bfce100feb02dd46deab8a920f14d80ab1327ea8
Cr-Commit-Position: refs/heads/master@{#348040}

Powered by Google App Engine
This is Rietveld 408576698