MD Downloads: compute description and tag via data binding

chrome/browser/ui/webui/downloads_dom_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/downloads_dom_handler.h"
 
 #include <algorithm>
 #include <functional>
 
 #include "base/basictypes.h"
@@ skipping 170 matching lines @@
   file_value->SetString("file_name", file_name);
   file_value->SetString("url", download_item->GetURL().spec());
   file_value->SetBoolean("otr", incognito);
   file_value->SetInteger("total", static_cast<int>(
       download_item->GetTotalBytes()));
   file_value->SetBoolean("file_externally_removed",
                          download_item->GetFileExternallyRemoved());
   file_value->SetBoolean("retry", false); // Overridden below if needed.
   file_value->SetBoolean("resume", download_item->CanResume());
 
+  const char* danger_type = "";
+  base::string16 last_reason_text;
+  base::string16 progress_status_text;
+
   switch (download_item->GetState()) {
     case content::DownloadItem::IN_PROGRESS: {
       if (download_item->IsDangerous()) {
         file_value->SetString("state", "DANGEROUS");
         // These are the only danger states that the UI is equipped to handle.
         DCHECK(download_item->GetDangerType() ==
                    content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE ||
                download_item->GetDangerType() ==
                    content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL ||
                download_item->GetDangerType() ==
                    content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT ||
                download_item->GetDangerType() ==
                    content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT ||
                download_item->GetDangerType() ==
                    content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST ||
                download_item->GetDangerType() ==
                    content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED);
-        const char* danger_type_value =
-            GetDangerTypeString(download_item->GetDangerType());
-        file_value->SetString("danger_type", danger_type_value);
+        danger_type = GetDangerTypeString(download_item->GetDangerType());
       } else if (download_item->IsPaused()) {
         file_value->SetString("state", "PAUSED");
       } else {
         file_value->SetString("state", "IN_PROGRESS");
       }
-      file_value->SetString("progress_status_text",
-                            download_model.GetTabProgressStatusText());
+      progress_status_text = download_model.GetTabProgressStatusText();
 
       int percent = download_item->PercentComplete();
       if (!MdDownloadsEnabled())
         percent = std::max(0, percent);
       file_value->SetInteger("percent", percent);
 
       file_value->SetInteger("received",
           static_cast<int>(download_item->GetReceivedBytes()));
       break;
     }
 
     case content::DownloadItem::INTERRUPTED:
       file_value->SetString("state", "INTERRUPTED");
-
-      file_value->SetString("progress_status_text",
-                            download_model.GetTabProgressStatusText());
+      progress_status_text = download_model.GetTabProgressStatusText();
 
       if (download_item->CanResume()) {
         file_value->SetInteger("percent",
             static_cast<int>(download_item->PercentComplete()));
       }
       file_value->SetInteger("received",
           static_cast<int>(download_item->GetReceivedBytes()));
-      file_value->SetString("last_reason_text",
-                            download_model.GetInterruptReasonText());
+      last_reason_text = download_model.GetInterruptReasonText();
       if (content::DOWNLOAD_INTERRUPT_REASON_CRASH ==
           download_item->GetLastReason() && !download_item->CanResume())
         file_value->SetBoolean("retry", true);
       break;
 
     case content::DownloadItem::CANCELLED:
       file_value->SetString("state", "CANCELLED");
       file_value->SetBoolean("retry", true);
       break;
 
     case content::DownloadItem::COMPLETE:
       DCHECK(!download_item->IsDangerous());
       file_value->SetString("state", "COMPLETE");
       break;
 
     case content::DownloadItem::MAX_DOWNLOAD_STATE:
       NOTREACHED();
   }
 
+  file_value->SetString("danger_type", danger_type);
+  file_value->SetString("last_reason_text", last_reason_text);
+  file_value->SetString("progress_status_text", progress_status_text);
+
   return file_value;
 }
 
 // Filters out extension downloads and downloads that don't have a filename yet.
 bool IsDownloadDisplayable(const content::DownloadItem& item) {
   return !download_crx_util::IsExtensionDownload(item) &&
          !item.IsTemporary() &&
          !item.GetFileNameToReportUser().empty() &&
          !item.GetTargetFilePath().empty() &&
          DownloadItemModel(
@@ skipping 445 matching lines @@
   return web_ui()->GetWebContents();
 }
 
 void DownloadsDOMHandler::CallUpdateAll(const base::ListValue& list) {
   web_ui()->CallJavascriptFunction("downloads.Manager.updateAll", list);
 }
 
 void DownloadsDOMHandler::CallUpdateItem(const base::DictionaryValue& item) {
   web_ui()->CallJavascriptFunction("downloads.Manager.updateItem", item);
 }